Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #13

Open
1 of 6 tasks
davide-f opened this issue Sep 22, 2023 · 7 comments
Open
1 of 6 tasks

Improve documentation #13

davide-f opened this issue Sep 22, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@davide-f
Copy link
Member

davide-f commented Sep 22, 2023

Describe the feature you'd like to see

Documentation shall be improved. In particular:

  • Add readthedocs
  • Improve docstrings
  • Add more description of the distribution repo.
    E.g. (thanks katia):
    • what are the main inputs needed to run the model and under which assumptions are obtained approximations of these inputs?
    • which configuration parameters should be looked for to adjust the model configuration?
    • a short description related to the essence of the problems which can be solved by the model (I think, a picture and a couple of reference to the published works would work great)
@davide-f davide-f added the enhancement New feature or request label Sep 22, 2023
@ekatef
Copy link
Member

ekatef commented Sep 24, 2023

@davide-f Thanks a lot for adding the issue on docs.

Adding a couple of suggestions after some playing with the code. According to my impression, it would be great to have answers on the following questions:
[ ] what are the main inputs needed to run the model and under which assumptions are obtained approximations of these inputs?
[ ] which configuration parameters should be looked for to adjust the model configuration?
[ ] a short description related to the essence of the problems which can be solved by the model (I think, a picture and a couple of reference to the published works would work great)

@davide-f does it sound reasonable for you? Obviously, happy to contribute to each of the points.

@TomFer97
Copy link

TomFer97 commented Oct 9, 2023

I've tried to look on how to implement it

@ekatef
Copy link
Member

ekatef commented Oct 9, 2023

I've tried to look on how to implement it

Hey @TomFer97! That is amazing :)

Which tools do you consider?

Could be pypsa-earth experience probably helpful? It is based on using sphinx, which allows to use markdown syntax, using read-the-docs infrastructure to host the docs and use some nice automated features like fetching doc-strings and rendering config tables. (Sorry if it sounds trivial for you!)

@TomFer97
Copy link

It's the first experience for me in this kind of thing. I'll to come up with something for friday :)

@ekatef
Copy link
Member

ekatef commented Oct 17, 2023

It's the first experience for me in this kind of thing. I'll to come up with something for friday :)

Then, sphinx may be a way to go :)
There are some practical hints on how to start.

@davide-f
Copy link
Member Author

FYI, a draft implementation of readthedocs is online :)
https://pypsa-distribution.readthedocs.io/en/latest/

@ekatef
Copy link
Member

ekatef commented Dec 16, 2023

It may be worth to add a brief explanation on how to run a tutorial case and a full-scale simulation. In particular, would be great to mention a proper set-up of tutorial parameter in config.pypsa-earth.yaml to avoid issues described in #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants