Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust a set of demo-notebooks #6

Open
ekatef opened this issue Oct 24, 2022 · 4 comments
Open

Adjust a set of demo-notebooks #6

ekatef opened this issue Oct 24, 2022 · 4 comments
Assignees

Comments

@ekatef
Copy link
Member

ekatef commented Oct 24, 2022

Currently notebooks keep plenty of valuable ideas on development, validation and visualisation. However, they were created along with the mainstream development process and it was not always possible/feasible to provide a full set of instructions how to reproduce the model output being used in the notebook.

It makes sense to select a set of the notebooks and revise them to ensure that it's easy to fully reproduce them. In particular, it a network model for a selected country can be attached as discussed with @pz-max.

@pz-max pz-max assigned pz-max and unassigned pz-max Oct 25, 2022
@pz-max
Copy link
Member

pz-max commented Oct 25, 2022

Hi @AnasAlgarei ,

  1. I will clean-up the notebooks folder
  2. Could you compile each for the Nigeria case & fix the description if necessary?

@pz-max pz-max self-assigned this Oct 25, 2022
@AnasAlgarei
Copy link
Collaborator

Hi @AnasAlgarei ,

  1. I will clean-up the notebooks folder
  2. Could you compile each for the Nigeria case & fix the description if necessary?

Sure, I will do that and report if there are any issues

@pz-max
Copy link
Member

pz-max commented Oct 26, 2022

@AnasAlgarei I just did the first step. There are some notebooks that start with 0. As probably done for the other notebooks can you add a description that fixes:

  • Unclear what workflow needs to be executed so that the notebook can work
  • Unclear what config.yaml was necessary to create the illustrations
  • Run PyPSA-Earth for whole Africa to plot the outputs & also run in a parallel the mode for Nigeria (new folder). I think some notebooks may require Nigeria data instead of continental data

As mentioned above, I suggest compiling each notebook to learn from the output/picture, and try to fix naming pypsa-africa -> pypsa-earth. Remember to only commit once for one notebook. This means do all the changes for one notebook, clear all outputs, start from fresh kernel, compile the whole notebook & the commit 💯

@pz-max pz-max assigned AnasAlgarei and unassigned pz-max Oct 26, 2022
@AnasAlgarei
Copy link
Collaborator

@AnasAlgarei I just did the first step. There are some notebooks that start with 0. As probably done for the other notebooks can you add a description that fixes:

  • Unclear what workflow needs to be executed so that the notebook can work
  • Unclear what config.yaml was necessary to create the illustrations
  • Run PyPSA-Earth for whole Africa to plot the outputs & also run in a parallel the mode for Nigeria (new folder). I think some notebooks may require Nigeria data instead of continental data

As mentioned above, I suggest compiling each notebook to learn from the output/picture, and try to fix naming pypsa-africa -> pypsa-earth. Remember to only commit once for one notebook. This means do all the changes for one notebook, clear all outputs, start from fresh kernel, compile the whole notebook & the commit 💯

Running Nigeria shouldn't be a problem, I'll try for whole Africa as well and hopefully it works, as for the notebooks' outputs, as I recall, some of them would work for Nigeria but not for other countries (i.e. Saudi Arabia). However, I will try some of the countries that I already solved and report any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants