Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPError: 504 Server Error: Gateway Time-out for url: https://api.helpscout.net/v2/oauth2/token #16948

Closed
sentry-io bot opened this issue Oct 22, 2024 · 0 comments · Fixed by #16957
Closed

HTTPError: 504 Server Error: Gateway Time-out for url: https://api.helpscout.net/v2/oauth2/token #16948

sentry-io bot opened this issue Oct 22, 2024 · 0 comments · Fixed by #16957
Labels
admin Features needed for the Admin UI (people running the site) bug 🐛

Comments

@sentry-io
Copy link

sentry-io bot commented Oct 22, 2024

Add resilience to remove call failures, either by retrying the http call (can tasks use self.http.* methods?) or retrying the entire task (by raising a RetryableException, see #16377 for an example)

Sentry Issue: WAREHOUSE-PRODUCTION-245

HTTPError: 504 Server Error: Gateway Time-out for url: https://api.helpscout.net/v2/oauth2/token
(6 additional frame(s) were not displayed)
...
  File "warehouse/tasks.py", line 90, in __call__
    return super().__call__(*(self.get_request(),) + args, **kwargs)
  File "warehouse/tasks.py", line 73, in run
    result = original_run(*args, **kwargs)
  File "warehouse/observations/tasks.py", line 97, in report_observation_to_helpscout
    helpdesk_service = request.find_service(IHelpDeskService)
  File "warehouse/helpdesk/services.py", line 104, in create_service
    resp.raise_for_status()
@sentry-io sentry-io bot added the admin Features needed for the Admin UI (people running the site) label Oct 22, 2024
miketheman added a commit to miketheman/warehouse that referenced this issue Oct 23, 2024
@miketheman
fix: retry token on error
6097144 
Obtaining the token can fail, so retry in failures beyond the ones that
are handled by `request.http`.

Fixes pypi#16948

Signed-off-by: Mike Fiedler <[email protected]>
@miketheman miketheman mentioned this issue Oct 23, 2024
Merged
miketheman added a commit to miketheman/warehouse that referenced this issue Oct 23, 2024
@miketheman
fix: retry token on error
93ff48b 
Obtaining the token can fail, so retry in failures beyond the ones that
are handled by `request.http`.

Fixes pypi#16948

Signed-off-by: Mike Fiedler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
admin Features needed for the Admin UI (people running the site) bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: retry token on error miketheman/warehouse
1 participant
@miketheman