-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest types-requests
breaks deps build, surfaces urllib3 chain issue
#14671
Labels
dependencies
Pull requests that update a dependency file
Comments
miketheman
added a commit
to miketheman/warehouse
that referenced
this issue
Oct 2, 2023
Pinning `urllib3` changes nothing, since we're already there, but prevents future breakage until we can upgrade. Pinning `types-requests` prevents us from losing `types-urllib3` until we can upgrade `urllib3` past 2.0. Refs: pypi#14671 Signed-off-by: Mike Fiedler <[email protected]>
miketheman
added a commit
to miketheman/warehouse
that referenced
this issue
Oct 13, 2023
And associated stubs. We exclude boto from dependabot due to frequency of updates. This upgrade includes the ability to use urllib3. Refs: boto/botocore#3034 We will still need to handle the elasticsearch dependency on its own. Refs: pypi#14671 Signed-off-by: Mike Fiedler <[email protected]>
Looks like But we're pinned back: warehouse/requirements/main.in Line 16 in 56f0f6c
|
Ah, this is because our Elasticsearch provider doesn't work with newer versions of Might be time to replace our search backend... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The latest
types-requests
package removes a dependency ontypes-urllib3
, and the typeshed has completely removedurllib3
types from the shed, since they are available in 2.0.x series.python/typeshed#10812
We are unable to upgrade to urllib3 yet, as some other tools pin to lower than 2.x
<2
, and even up to 7.17.9 https://github.com/elastic/elasticsearch-py/blob/deccbb732f17eee0937b7ec5980792849a2393d4/setup.py#L55 )I'll pin urllib3 to <2 to resolve a lot of these chains until we can resolve the above.
The text was updated successfully, but these errors were encountered: