Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plotting resids with PDC #164

Open
mnfienen opened this issue Aug 13, 2020 · 7 comments
Open

plotting resids with PDC #164

mnfienen opened this issue Aug 13, 2020 · 7 comments

Comments

@mnfienen
Copy link
Collaborator

In cases where ++ies_drop_conflicts is True, it would be nice to eliminate those dropped obs (especially if they are really really bad!) from plots like 1to1 plots. A simple flag could be supplied to pst.plot(kind='1to1', drop_pdc=True) for example, that reads the csv file with PDC-dropped obs and just removes them before plotting.

I can implement, but wanted to see if anyone has objections or other ideas of how to deal.

@jwhite-usgs
Copy link
Collaborator

I think we do need to get better at handling conflicts in general. But instead of dropping, what about having them washed out or otherwise colored differently or at least have that option? There is a more advanced PDC detection routine in helpers now so we could potentially just call that under the hood in the plotting so that we dont have an external file dependency (that may change in the future!). Just my thoughts.

@jtwhite79
Copy link
Collaborator

@mnfienen - any interest in this option still?

@mnfienen
Copy link
Collaborator Author

Yeah - I do think this might be useful (although I've been going rogue with 1to1 plots lately). Maybe could have two options for pdc_plot like 'drop' or 'gray'? If that's cool, maybe I can implement.

Also, for some recent work, found it valuable to plot 1to1 with error bars in both obs and modeled like the attached. Maybe can fold that into pyemu?

image

@jtwhite79
Copy link
Collaborator

Those plots look awesome! We could also just have variants on the 1-to-1 plots since all of us GW modelers are so obsessed with it - like a Pst.plot(kind="1to1-fancysauce") ? I like showing the meas error bars too!

@jtwhite79
Copy link
Collaborator

@mnfienen - any movement on this?

@mnfienen
Copy link
Collaborator Author

@jtwhite79 nope lol. I can try and revisit though!

@briochh
Copy link
Collaborator

briochh commented Jan 18, 2023

@mnfienen, happy for me to move this to discussions? Might be good to revisit when whoever has the time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants