Skip to content

Path traversal in PackageIndex.download leads to Arbitrary File Write. #4946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaraco opened this issue Apr 14, 2025 · 0 comments
Closed

Path traversal in PackageIndex.download leads to Arbitrary File Write. #4946

jaraco opened this issue Apr 14, 2025 · 0 comments
Assignees
Labels

Comments

@jaraco
Copy link
Member

jaraco commented Apr 14, 2025

Vulnerable Code

    def _download_url(self, url, tmpdir):
        # Determine download filename
        #
        name, _fragment = egg_info_for_url(url)
        if name:
            while '..' in name:
                name = name.replace('..', '.').replace('\\', '_')
        else:
            name = "__downloaded__"  # default if URL has no path contents

        if name.endswith('.[egg.zip](http://egg.zip/)'):
            name = name[:-4]  # strip the extra .zip before download

 -->       filename = os.path.join(tmpdir, name)

Here: https://github.com/pypa/setuptools/blob/main/setuptools/package_index.py#L823

os.path.join() discards the first argument (tmpdir) if the second begins with a slash or drive letter.
name is derived from a URL without sufficient sanitization. While there is some attempt to sanitize by replacing instances of '..' with '.', it is insufficient.

PoC

Attached.
The script downloads a file from a local HTTP server using setuptools' PackageIndex bypassing tmp directory restrictions, and writing to a sensitive location.

$ python poc.py
Payload file: http://localhost:8000/%2fhome%2fuser%2f.ssh%2fauthorized_keys
Written to: /home/user/.ssh/authorized_keys

Risk Assessment

As easy_install and package_index are deprecated, the exploitation surface is reduced.
However, it seems this could be exploited in a similar fashion like CVE-2022-40897, and as described by POC 4 in CVE-2024-6345 report: via malicious URLs present on the pages of a package index.
https://huntr.com/bounties/d6362117-ad57-4e83-951f-b8141c6e7ca5

Impact: An attacker would be allowed to write files to arbitrary locations on the filesystem with the permissions of the process running the Python code, which could escalate to RCE depending on the context.

@jaraco jaraco self-assigned this Apr 19, 2025
@jaraco jaraco closed this as completed in 250a6d1 Apr 19, 2025
@jaraco jaraco changed the title Undisclosed security vulnerability Path traversal in [PackageIndex.download](http://packageindex.download/)() leads to Arbitrary File Write. Apr 19, 2025
@jaraco jaraco changed the title Path traversal in [PackageIndex.download](http://packageindex.download/)() leads to Arbitrary File Write. Path traversal in PackageIndex.download leads to Arbitrary File Write. Apr 19, 2025
@jaraco jaraco added the bug label Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant