Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming the default branch #8948

Closed
pradyunsg opened this issue Oct 1, 2020 · 9 comments
Closed

Renaming the default branch #8948

pradyunsg opened this issue Oct 1, 2020 · 9 comments
Labels
type: maintenance Related to Development and Maintenance Processes

Comments

@pradyunsg
Copy link
Member

There's lots of good reasons to move away from master as the name for the default branch of this project. This GH issue is for figuring out the logistical parts of making this change here.

If you're interested in arguing that we don't make this change, I request that you please file a separate issue.

@pradyunsg pradyunsg added the type: maintenance Related to Development and Maintenance Processes label Oct 1, 2020
@pradyunsg
Copy link
Member Author

GitHub is investing in tooling to make the transition easier, and it might likely a good idea to wait for that. From https://github.com/github/renaming/:

If you haven’t renamed your default branch yet, consider waiting until later this year. We’re investing in tools to make renaming the default branch of an existing repository a seamless experience for both maintainers and contributors.

@pradyunsg pradyunsg pinned this issue Mar 26, 2021
@pradyunsg
Copy link
Member Author

https://github.com/github/renaming/ has happened. I'll be making PRs to prepare for this over the weekend, and making this change this weekend as well.

/cc @pypa/pip-team in case someone has thoughts. :)

@pfmoore
Copy link
Member

pfmoore commented Mar 26, 2021

+1 on doing this. There will be impact (we can minimise but not eliminate it) but in my experience it's manageable.

@pradyunsg
Copy link
Member Author

Done in #9743 and made the switch now. I'll keep an eye out for CI issues, if any new ones arise. :)

@pradyunsg
Copy link
Member Author

Needed to update our bot for this (pypa/browntruck@8adbb68) but the deployment of that change failed. :(

@pradyunsg
Copy link
Member Author

ReadTheDocs' default branch needed to be updated in their admin UI.

@pradyunsg
Copy link
Member Author

Oh hey, this also broke Azure Pipelines, since that was looking for the old branch name. For now, I've just removed it via #9759.

@pradyunsg
Copy link
Member Author

I consider this done now.

@pradyunsg pradyunsg unpinned this issue Apr 24, 2021
@pradyunsg
Copy link
Member Author

ReadTheDocs' default branch needed to be updated in their admin UI.

Upstream issue: readthedocs/readthedocs.org#7907

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

No branches or pull requests

2 participants