Merge pull request #9171 from webknjaz/bugfixes/docs-feedback-sphinxext-orphan

pradyunsg · web-flow · commit d91b7d9e88ea · 2020-11-29T19:17:18.000Z
diff --git a/docs/docs_feedback_sphinxext.py b/docs/docs_feedback_sphinxext.py
@@ -111,7 +111,7 @@ def _modify_rst_document_source_on_read(
     orphan_mark = ':orphan:'
     is_orphan = orphan_mark in source[0]
     if is_orphan:
-        source[0].replace(orphan_mark, '')
+        source[0] = source[0].replace(orphan_mark, '')
     else:
         orphan_mark = ''
 
diff --git a/news/9171.trivial.rst b/news/9171.trivial.rst
@@ -0,0 +1,3 @@
+Fixed moving the ``:orphan:`` to top of documents in the Sphinx
+extension for collecting the UX feedback from docs (initially
+introduced in PR #8848).

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+Fixed moving the ``:orphan:`` to top of documents in the Sphinx
	`2`	`+extension for collecting the UX feedback from docs (initially`
	`3`	`+introduced in PR #8848).`