Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping (the "required" state for) Travis? #395

Closed
brettcannon opened this issue Feb 2, 2021 · 21 comments
Closed

Consider dropping (the "required" state for) Travis? #395

brettcannon opened this issue Feb 2, 2021 · 21 comments

Comments

@brettcannon
Copy link
Member

Personal experience with CPython says all CI fails, so you either don't require any of them or you stick with one and deal with its shortcomings rather than dealing with N tools' shortcomings.

Travis is currently not returning any status and since it's required I can't merge any PRs without an admin override. I'm personally fine just going with GitHub Actions as I don't think Travis adds much benefit. But if people want to keep it then can we consider changing the status check requirement for it?

@di
Copy link
Member

di commented Feb 2, 2021

Something odd is going on with our Travis-CI account:

Builds have been temporarily disabled for private and public repositories due to a negative credit balance. Please go to the Plan page to replenish your credit balance.

image

(cc @ewdurbin)

@di
Copy link
Member

di commented Feb 2, 2021

If we're fully ported to GitHub Actions, I don't see any reason to continue using Travis here (especially if we're consuming credits that other PyPA projects may actually need more than us).

@pradyunsg
Copy link
Member

I'd say let's just take out Travis CI.

@brettcannon
Copy link
Member Author

I think the IRC integration is the only thing we are missing, otherwise we actually have integrated with GHA than Travis at this point.

I have gone ahead and turned off the webhook to see how this goes. If it works out then we can delete the hook, .travis.yml and ask someone to remove the Travis integration (I don't appear to have the appropriate permissions; maybe org admin can do it?).

@pradyunsg
Copy link
Member

Given that I have travis-ci muted in IRC, I don't think anyone cares about that integration at this point. :)

Your plan sounds great to me!

@brettcannon
Copy link
Member Author

I've tweaked the status check requirements to only be GHA so that we control it while we see how this goes. I say we give it a month, and if it works out then we can drop Travis.

@mayeut
Copy link
Member

mayeut commented Feb 6, 2021

Does anybody here have a clue what's happening with our Travis-CI account or if there's someone in charge of that account ?
I guess we had some (maybe free) credits credited every day/month since travis-CI changed its policy and up-until end of January but that stopped for some reason ?
Happy to take this discussion elsewhere but I'm not sure discuss.python.org is appropriate.

@di
Copy link
Member

di commented Feb 6, 2021

It looks like on Jan 29th, Travis switched us to a free plan with 10K build credits, but we're currently in a hole of -930 credits that we're not recovering from. I reached out to support.

@di
Copy link
Member

di commented Feb 9, 2021

The PyPA travis account has been temporarily restored, but I'd still encourage this project (and others) to migrate to Actions.

@mayeut
Copy link
Member

mayeut commented Feb 9, 2021

Thanks for the feedback @di
Could you expand a bit on "temporarily" ?

pypa/manylinux & pypa/auditwheel could really benefit from travis-ci for aarch64/ppc64le/s390x where those architectures are natively supported (using qemu on GHA works but gives a build time of nearly 5 hours vs 30-40 minutes on travis-ci).

@di
Copy link
Member

di commented Feb 9, 2021

@mayeut We're currently paying for a paid plan and waiting to see if we'll get renewed credits. The PSF is currently footing the bill but I think we can ensure that we don't pull the rug out from under pypa/manylinux and pypa/auditwheel as long as there isn't a better alternative.

My encouragement is for projects like pypa/packaging that don't really need to be on Travis vs. another CI provider, and can help us reduce the overall Travis usage by migrating.

@brettcannon
Copy link
Member Author

Then I'm up for cutting off Travis now instead of waiting until the end of the month.

@di
Copy link
Member

di commented Feb 9, 2021

FWIW this is the usage breakdown over the two months:

image

@brettcannon
Copy link
Member Author

At least we are the cheap one. 😉

@pradyunsg
Copy link
Member

pradyunsg commented Feb 11, 2021

Hmm... Is there something from pip still on Travis CI?

Last I checked, every pip commit resulted in upto ~15 hours of machine time across our various workers across all platforms, so I'm not surprised that it's on top.

@di
Copy link
Member

di commented Feb 11, 2021

Hmm... Is there something from pip still on Travis CI?

@pradyunsg looks like yes: https://travis-ci.com/github/pypa/pip/builds

@brettcannon
Copy link
Member Author

So, drop Travis?

@pradyunsg
Copy link
Member

Yup.

@ewdurbin
Copy link
Member

OK, I think that's done!

@brettcannon
Copy link
Member Author

Thanks @ewdurbin ! And with 6b659ab I think we are all cleaned up!

@pradyunsg
Copy link
Member

@pradyunsg looks like yes: https://travis-ci.com/github/pypa/pip/builds

FYI: This got removed 2 months ago -- pypa/pip#9759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants