Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXES: #2961 #2962

Merged
merged 1 commit into from
Jan 4, 2024
Merged

FIXES: #2961 #2962

merged 1 commit into from
Jan 4, 2024

Conversation

bwagner
Copy link
Contributor

@bwagner bwagner commented Jan 3, 2024

No description provided.

Copy link
Contributor

github-actions bot commented Jan 3, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@bwagner
Copy link
Contributor Author

bwagner commented Jan 3, 2024

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jan 3, 2024
@JorjMcKie
Copy link
Collaborator

Possible arguments for loading a page are both, integers (page_number) and pairs (chapter, page_number).

bwagner pushed a commit to bwagner/PyMuPDF that referenced this pull request Jan 4, 2024
@julian-smith-artifex-com
Copy link
Collaborator

This change looks good, thanks.

But please rebase into a single commit, and exclude commit #0e2c07a0eff1ac "@bwagner has signed the CLA from Pull Request".

@julian-smith-artifex-com
Copy link
Collaborator

Oh, one other thing, could you describe what you're fixing explicitly, instead of just giving the Issue number? For example: "Improve handling of incorrect types passed to Document.__get_item().

@bwagner
Copy link
Contributor Author

bwagner commented Jan 4, 2024

Ah, sorry, need to rebase into single commit. Will try again!

@julian-smith-artifex-com
Copy link
Collaborator

Thanks for that, all looks good so merging now.

@julian-smith-artifex-com julian-smith-artifex-com merged commit a88e737 into pymupdf:main Jan 4, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants