Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connect message names with RPC calls #57

Open
BenediktBurger opened this issue Sep 19, 2023 · 2 comments · May be fixed by #56
Open

Connect message names with RPC calls #57

BenediktBurger opened this issue Sep 19, 2023 · 2 comments · May be fixed by #56

Comments

@BenediktBurger
Copy link
Member

On the control protocol page, we uses message names like "SIGNIN" etc. Now we use RPC calls with different method names.

One possibility would be to state, that "SIGNIN" stands for a rpc call for the "sign_in" method.
@bilderbuchi
Copy link
Member

I think we should be consistent between message names and method names, that's easier to keep track of (less mental overhead keeping two slightly different designations in your head).

BenediktBurger added a commit that referenced this issue Sep 27, 2023
@BenediktBurger
Change message names in the control protocol according to the RPC mes…
5ce9ab6 
…sage names. Closes #57
@BenediktBurger BenediktBurger linked a pull request Oct 11, 2023 that will close this issue
Suggestion for message types. #56
Open
2 tasks
@BenediktBurger
Copy link
Member Author

I adjusted the text in #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Suggestion for message types. pymeasure/leco-protocol
2 participants
@bilderbuchi @BenediktBurger