Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allocate_budget_to_maximize_response() doc string could be clearer #1161

Open
cluhmann opened this issue Nov 4, 2024 · 1 comment
Open
Labels
docs Improvements or additions to documentation MMM optimizer

Comments

@cluhmann
Copy link
Contributor

cluhmann commented Nov 4, 2024

The following arguments could use some additional clarification:

  • budget_bounds: could use an example to illustrate the structure
  • custom_constraints: definitely needs an example. Totally unclear how to use this at the moment.
  • quantile: doc string states this is "The quantile to use for recovering transformation parameters". But a quartile of what? Why are transformation parameters being "recovered" and why are quantiles needed for this process?
  • noise_level: doc string states that this is "The level of noise added to the allocation strategy". But it's not clear what this means or where this noise is added or why.
@cluhmann cluhmann added docs Improvements or additions to documentation MMM labels Nov 4, 2024
@wd60622
Copy link
Contributor

wd60622 commented Nov 4, 2024

@cetagostini some feedback for #1151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation MMM optimizer
Projects
None yet
Development

No branches or pull requests

2 participants