Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "generic" meta types consistently #87

Open
brandonwillard opened this issue Oct 30, 2019 · 0 comments
Open

Use "generic" meta types consistently #87

brandonwillard opened this issue Oct 30, 2019 · 0 comments
Labels
bug Something isn't working enhancement New feature or request important Features and issues that need to be addressed ASAP meta graph This issue involves the meta graph objects

Comments

@brandonwillard
Copy link
Contributor

brandonwillard commented Oct 30, 2019

In some instances, we automatically create logic variables as stand-ins for unspecified meta object components (e.g. #35, TFlowMetaOp.outputs); following #84, we should always produce properly "typed" generic objects and we should also restrict meta object inputs to the expected "types" (whenever possible).

For example, TFlowMetaOp.outputs would ideally return something strictly unifiable with a tuple of TFlowMetaTensor objects. As well, we shouldn't allow a strictly logic variable argument for TFlowMetaOp.op_def, since it's possible to create a TFlowMetaOpDef object with strictly logic variable arguments—making it just as generic, but properly "typed" (i.e. will only unify with a TFlowMetaOpDef, but will unify with any TFlowMetaOpDef).

This change will probably need to come alongside an easy way to generate these generic meta types (e.g. a "generic" TFlowMetaOp requires a "generic" TFlowMetaOpDef).

Such a consistency would also simplify the code base quite a bit, since there are numerous places where isvar is used to check whether or not a property is available.

@brandonwillard brandonwillard added bug Something isn't working enhancement New feature or request important Features and issues that need to be addressed ASAP labels Oct 30, 2019
@brandonwillard brandonwillard changed the title Automatically Generated Logic Variable Meta Object Components Use "generic" meta types consistently Oct 30, 2019
@brandonwillard brandonwillard added the meta graph This issue involves the meta graph objects label Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request important Features and issues that need to be addressed ASAP meta graph This issue involves the meta graph objects
Projects
None yet
Development

No branches or pull requests

1 participant