[refactor] Change the name of the stashed messages list in PyLinter

Author: Pierre-Sassoulas

pylint/config/callback_actions.py

@@ -381,9 +381,9 @@ def __call__(
             try:
                 self.linter.disable(msgid)
             except exceptions.UnknownMessageError:
-                self.linter._stashed_bad_option_value_messages[
-                    self.linter.current_name
-                ].append((option_string, msgid))
+                self.linter._stashed_messages[self.linter.current_name].append(
+                    (option_string, msgid)
+                )
 
 
 class _EnableAction(_AccessLinterObjectAction):
@@ -402,9 +402,9 @@ def __call__(
             try:
                 self.linter.enable(msgid)
             except exceptions.UnknownMessageError:
-                self.linter._stashed_bad_option_value_messages[
-                    self.linter.current_name
-                ].append((option_string, msgid))
+                self.linter._stashed_messages[self.linter.current_name].append(
+                    (option_string, msgid)
+                )
 
 
 class _OutputFormatAction(_AccessLinterObjectAction):

pylint/config/config_initialization.py

@@ -91,7 +91,7 @@ def _config_initialization(
             "unrecognized-option", args=unrecognized_options_message, line=0
         )
 
-    linter._emit_bad_option_value()
+    linter._emit_stashed_messages()
 
     # Set the current module to configuration as we don't know where
     # the --load-plugins key is coming from

pylint/lint/message_state_handler.py

@@ -56,15 +56,14 @@ def __init__(self, linter: PyLinter) -> None:
         }
         self._pragma_lineno: dict[str, int] = {}
         # TODO: 3.0: Update key type to str when current_name is always str
-        self._stashed_bad_option_value_messages: defaultdict[
+        self._stashed_messages: defaultdict[
             str | None, list[tuple[str | None, str]]
         ] = defaultdict(list)
-        """Bad option values for --enable and --disable are encountered too early to
-        warn about them, i.e. before all option providers have been fully parsed.
+        """Some messages in the options (for --enable and --disable) are encountered
+        too early to warn about them.
 
-        Thus,
-        this dict stores option_value and msg_id needed to (later) emit the
-        bad-option-value messages keyed on module names.
+        i.e. before all option providers have been fully parsed. Thus, this dict stores
+        option_value and msg_id needed to (later) emit the messages keyed on module names.
         """
 
     def _set_one_msg_status(

pylint/lint/pylinter.py

@@ -1226,15 +1226,15 @@ def add_ignored_message(
                 line,
             )
 
-    def _emit_bad_option_value(self) -> None:
-        for modname in self._stashed_bad_option_value_messages:
+    def _emit_stashed_messages(self) -> None:
+        for modname in self._stashed_messages:
             self.linter.set_current_module(modname)
-            values = self._stashed_bad_option_value_messages[modname]
+            values = self._stashed_messages[modname]
             for option_string, msg_id in values:
                 self.add_message(
                     "bad-option-value",
                     args=(option_string, msg_id),
                     line=0,
                     confidence=HIGH,
                 )
-        self._stashed_bad_option_value_messages = collections.defaultdict(list)
+        self._stashed_messages = collections.defaultdict(list)