Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accumulate run signals with scoped labels not objects #173

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

liamhuber
Copy link
Member

The scoped label will always be unique, so just store that.

The point is that as we move towards storage and serialization, this gives one less complex object that needs to live on the node.

Right now I lean towards restoring graphs by re-executing from the top, but just not actually re-running nodes who have the same input as they had at their last execution (optional (for slow nodes), evaluated by hash comparison). In that case, we don't need to reload this data as the set will get re-populated at run-time. However, IMO it doesn't hurt to have it serialized, and it will be necessary for finding graph state if we wind up taking a different path to reloading.

@liamhuber liamhuber requested a review from samwaseda January 22, 2024 22:43
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/store_scoped_labels

Copy link

codacy-production bot commented Jan 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (46a5534) 2596 2218 85.44%
Head commit (651c2bd) 2596 (+0) 2218 (+0) 85.44% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#173) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@coveralls
Copy link

coveralls commented Jan 22, 2024

Pull Request Test Coverage Report for Build 7618377654

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 90.31%

Totals Coverage Status
Change from base Build 7617353667: 0.006%
Covered Lines: 4697
Relevant Lines: 5201

💛 - Coveralls

@liamhuber liamhuber added the format_black trigger the Black formatting bot label Jan 22, 2024
@liamhuber liamhuber mentioned this pull request Jan 24, 2024
@liamhuber liamhuber merged commit e990902 into main Jan 24, 2024
16 checks passed
@liamhuber liamhuber deleted the store_scoped_labels branch January 24, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black trigger the Black formatting bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants