Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working dir emptiness check #157

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Conversation

liamhuber
Copy link
Member

Just very minor convenience changes to the filesystem stuff: adds a property DirectoryObject.is_empty that checks agains length, and modifies deletion so you can choose to only delete if it's empty: DirectoryObject.(self, only_if_empty: bool = False)

@liamhuber liamhuber requested a review from samwaseda January 10, 2024 19:42
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/working_dir

Copy link

codacy-production bot commented Jan 10, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f11d7ea) 2569 2192 85.33%
Head commit (85f153d) 2572 (+3) 2195 (+3) 85.34% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#157) 5 5 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@liamhuber and others added 2 commits January 10, 2024 13:18
To bring it in line with `pathlib.Path.is_*` syntax
@liamhuber liamhuber merged commit 97d0114 into registration_by_identifier_alone Jan 15, 2024
15 checks passed
@liamhuber liamhuber deleted the working_dir branch January 15, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants