-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registration by identifier alone #156
Conversation
Using the package identifiers
And demote its position in the signature
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
No change to the default behaviour
It only depends on pathlib and seems generically useful to me, so off to snippets it goes!
To bring it in line with `pathlib.Path.is_*` syntax
Working dir emptiness check
Move the `files` submodule over to `snippets`
Promotes the importance of the package identifier during registration -- it comes first in the signature, and specifying a domain is completely optional. Also gives item-access to registered packages from the creator using their package identifier as a key. E.g., together with recursive registration on modules from the parent branch, we could now write something like
This will be useful downstream for loading saved workflows, and maybe also for macros -- basically whenever all we have/want is the package identifier. After all, the whole "domain" business for registration was just to make shortcuts like
Workflow.create.some_domain.NodeClass
for cases where the package identifier is long and hideous and we don't want to type it all the time.