Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise the intuitive type of error #146

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Raise the intuitive type of error #146

merged 1 commit into from
Jan 4, 2024

Conversation

liamhuber
Copy link
Member

Depending on how you tried to get something from a dot-dict, i.e. key errors from item access, attribute errors from attribute access.

Copy link

github-actions bot commented Jan 4, 2024

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/dotdict

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2f0e014) 2500 2133 85.32%
Head commit (9d2803c) 2503 (+3) 2136 (+3) 85.34% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#146) 4 4 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

github-actions bot commented Jan 4, 2024

Pull Request Test Coverage Report for Build 7414580192

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 90.264%

Totals Coverage Status
Change from base Build 7402051119: 0.01%
Covered Lines: 4543
Relevant Lines: 5033

💛 - Coveralls

@liamhuber liamhuber merged commit 1ea4ff6 into main Jan 4, 2024
16 of 17 checks passed
@liamhuber liamhuber deleted the dotdict branch January 4, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant