Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage: node and channel data should be able to be stored in HDF #153

Closed
liamhuber opened this issue Jan 8, 2024 · 1 comment · Fixed by #160
Closed

Storage: node and channel data should be able to be stored in HDF #153

liamhuber opened this issue Jan 8, 2024 · 1 comment · Fixed by #160
Assignees

Comments

@liamhuber
Copy link
Member

Or some other storage paradigm.

Forgetting for a moment all the bells and whistles of black-/white-listing different data types, or controlling the depth to which data is stored, or nodes that are smart enough to always re-run because their execution time is trivial compared to their file IO time, or storing nodes that only exist in a notebook, or saving and loading partially executed graphs... At a minimum, we need to be able to save a completed node or workflow-that-only-uses-registered-nodes, and re-load it later in its fully executed state.

Something like this should work and give us the right output data:

from pyiron_workflow import Workflow

wf = wf("my_stuff")
wf.foo = Workflow.create...
...
wf.save()

wf2 = wf("my_stuff")

assert(wf2 is not wf)
wf2.outputs

Where saving and loading worked automatically based off of the workflow label and the current working directory.

@liamhuber liamhuber self-assigned this Jan 8, 2024
@liamhuber liamhuber mentioned this issue Jan 12, 2024
7 tasks
@liamhuber liamhuber linked a pull request Jan 12, 2024 that will close this issue
7 tasks
@liamhuber
Copy link
Member Author

Just waiting for the bots to work on the latest release of h5io now. Then, assuming the tests are passing, #160 is ready to go and closes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant