Merge pull request #177 from pyiron/hotfix_set_running_false

🐛 stop running
pyiron · Jan 30, 2024 · a3f4a75 · a3f4a75
2 parents 1ce79ce + 1f3893d
commit a3f4a75
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/pyiron_workflow/composite.py b/pyiron_workflow/composite.py
@@ -195,6 +195,7 @@ def _parse_remotely_executed_self(self, other_self):
         # Un-parent existing nodes before ditching them
         for node in self:
             node._parent = None
+        other_self.running = False  # It's done now
         self.__setstate__(other_self.__getstate__())
 
     def disconnect_run(self) -> list[tuple[Channel, Channel]]:

diff --git a/tests/unit/test_macro.py b/tests/unit/test_macro.py
@@ -238,6 +238,10 @@ def test_with_executor(self):
 
         returned_nodes = result.result(timeout=120)  # Wait for the process to finish
         sleep(1)
+        self.assertFalse(
+            macro.running,
+            msg="Macro should be done running"
+        )
         self.assertIsNot(
             original_one,
             returned_nodes.one,