Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tinystore Draft #948

Closed
wants to merge 7 commits into from
Closed

Tinystore Draft #948

wants to merge 7 commits into from

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Jan 5, 2024

Includes #936 halfway.

@liamhuber There's still some problems with h5io_browser that I use to access the files. I think you will need to force python=3.10 to avoid a bug there that otherwise breaks reading data,

pmrv and others added 7 commits October 6, 2023 15:42
Also generalize it so that it can take any object that follows the
concurrent.futures interface
This required some rearchitecting of some of the nodes, but in particular made SeriesNodes much nicer
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

github-actions bot commented Jan 5, 2024

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_contrib/tinystore

@pmrv
Copy link
Contributor Author

pmrv commented Jan 5, 2024

Instead of ProjectAdapter you'll want to use the FilesystemProject or SingleHdfProject classes. (but see the updated notebooks as well.)

@liamhuber
Copy link
Member

Thanks!

@liamhuber There's still some problems with h5io_browser that I use to access the files. I think you will need to force python=3.10 to avoid a bug there that otherwise breaks reading data,

No worries, pyiron_workflow already specifies python>=3.10 anyhow (for type-hinting syntax IIRC).

@pmrv
Copy link
Contributor Author

pmrv commented Jan 5, 2024

Ah, but in this case 3.11 is the one that causes the problem. I will patch it by Monday, I think.

@liamhuber
Copy link
Member

Ah, but in this case 3.11 is the one that causes the problem. I will patch it by Monday, I think.

Indeed, that is more of a problem 😂 If you can patch that would be stellar, and Monday is fine -- despite my grand ambitions to work on this I spent most of my morning trying to track down a crash in the CI that I couldn't reproduce on my local machine 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants