Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlattenedStorage.split modifies original storage #1374

Open
pmrv opened this issue Mar 14, 2024 · 0 comments
Open

FlattenedStorage.split modifies original storage #1374

pmrv opened this issue Mar 14, 2024 · 0 comments
Assignees
@pmrv
Labels
bug Something isn't working

Comments

@pmrv
Copy link
Contributor

pmrv commented Mar 14, 2024

Reminder to myself:

Docstring promises a deep copy, but actually causes to delete "not split off" arrays from the original storage. Fix is to use copy.deepcopy instead of normal copy likely.

pyiron_base/pyiron_base/storage/flattenedstorage.py

Line 702 in d99259d

def split(self, array_names: Iterable[str]) -> "FlattenedStorage":

@pmrv pmrv added the bug Something isn't working label Mar 14, 2024
@pmrv pmrv self-assigned this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmrv pmrv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pmrv