Fixes non parsing of incar/job metainformation from vasprun #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ligerzero-ai
added
the
integration
pmrv
reviewed
Feb 2, 2024
Comment on lines
+621
to
+626
| except Exception as exc: | ||
| if name == "RANDOM_SEED": | ||
| # Handles the case where RANDOM SEED > 99999, which results in ***** | ||
| params[name] = None | ||
| else: | ||
| raise exc |
There was a problem hiding this comment.
Suggested change
| except Exception as exc: | |
| if name == "RANDOM_SEED": | |
| # Handles the case where RANDOM SEED > 99999, which results in ***** | |
| params[name] = None | |
| else: | |
| raise exc | |
| except Exception: | |
| if name == "RANDOM_SEED": | |
| # Handles the case where RANDOM SEED > 99999, which results in ***** | |
| params[name] = None | |
| else: | |
| raise |
Using raise inside an except block re-raises automatically. Can we also make the exception more specific?
pmrv
reviewed
Feb 2, 2024
| # LDAUL/J as 2**** | ||
| val = self._parse_from_incar(filename, param_name) | ||
| if val is None: | ||
| raise err |
There was a problem hiding this comment.
Suggested change
| raise err | |
| raise err from None |
This will clear up the stacktrace.
It feels a bit strange, to pre define the exception. It works and there's no down side, though.
pmrv
reviewed
Feb 2, 2024
Comment on lines
+596
to
+597
| # val = self._parse_from_incar(filename, param_name) | ||
| va |
There was a problem hiding this comment.
Feels like there's something missing here?
pmrv
reviewed
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1226