Skip to content

Commit ab1be3f

Browse files
author
Robert Pfeiffer
committed
Merge branch 'adding-more-assets' into develop
2 parents 223aa27 + e5aff0c commit ab1be3f

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

pythonforandroid/bootstraps/common/build/build.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -602,7 +602,7 @@ def parse_args_and_make_package(args=None):
602602
help='Used shared libraries included using <uses-library> tag in AndroidManifest.xml')
603603
ap.add_argument('--asset', dest='assets',
604604
action="append", default=[],
605-
metavar="/path/to/source:dest"
605+
metavar="/path/to/source:dest",
606606
help='Put this in the assets folder at assets/dest')
607607
ap.add_argument('--icon', dest='icon',
608608
help=('A png file to use as the icon for '

pythonforandroid/toolchain.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,7 @@ def add_parser(subparsers, *args, **kwargs):
491491
# However, it is also needed before the distribution is finally
492492
# assembled for locating the setup.py / other build systems, which
493493
# is why we also add it here:
494-
parser_packaging.add_argument(
494+
parser_packaging.add_argument(
495495
'--add-asset', dest='assets',
496496
action="append", default=[],
497497
help='Put this in the assets folder in the apk.')
@@ -593,13 +593,6 @@ def add_parser(subparsers, *args, **kwargs):
593593
args.unknown_args += ["--private", args.private]
594594
if hasattr(args, "build_mode") and args.build_mode == "release":
595595
args.unknown_args += ["--release"]
596-
for asset in args.assets:
597-
if ":" in asset:
598-
asset_src, asset_dest = asset.split(":")
599-
else:
600-
asset_src = asset_dest = asset
601-
# take abspath now, because build.py will be run in bootstrap dir
602-
args.unknown_args += ["--asset", os.path.abspath(asset_src)+":"+asset_dest]
603596
if hasattr(args, "ignore_setup_py") and args.ignore_setup_py:
604597
args.use_setup_py = False
605598

@@ -960,6 +953,14 @@ def _fix_args(args):
960953
fix_args = ('--dir', '--private', '--add-jar', '--add-source',
961954
'--whitelist', '--blacklist', '--presplash', '--icon')
962955
unknown_args = args.unknown_args
956+
957+
for asset in args.assets:
958+
if ":" in asset:
959+
asset_src, asset_dest = asset.split(":")
960+
else:
961+
asset_src = asset_dest = asset
962+
# take abspath now, because build.py will be run in bootstrap dir
963+
unknown_args += ["--asset", os.path.abspath(asset_src)+":"+asset_dest]
963964
for i, arg in enumerate(unknown_args):
964965
argx = arg.split('=')
965966
if argx[0] in fix_args:

0 commit comments

Comments
 (0)