From e027d7a1ac1d0a623fa4490336e5c08c0ff97865 Mon Sep 17 00:00:00 2001 From: Ankith <itsankith26@gmail.com> Date: Fri, 5 Jan 2024 10:15:02 +0530 Subject: [PATCH] Use drflac instead of libflac --- .../manylinux-build/docker_base/sdl_libs/build-sdl2-libs.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/buildconfig/manylinux-build/docker_base/sdl_libs/build-sdl2-libs.sh b/buildconfig/manylinux-build/docker_base/sdl_libs/build-sdl2-libs.sh index e82297724f..2cb7591d64 100644 --- a/buildconfig/manylinux-build/docker_base/sdl_libs/build-sdl2-libs.sh +++ b/buildconfig/manylinux-build/docker_base/sdl_libs/build-sdl2-libs.sh @@ -91,13 +91,13 @@ mkdir builddir && cd builddir # The SDL2MIXER_DEPS_SHARED flag make it use standard dynamic linking rather than # dlopen-ing the library itself. This is important for when auditwheel moves # libraries into the wheel. -# We prefer libflac, mpg123 and ogg-vorbis over SDL vendored implementations +# We prefer mpg123 and ogg-vorbis over SDL vendored implementations # at the moment. This can be changed later if need arises. +# libflac had link time issues on macs and windows(mingw) so we use drflac. # For now, libmodplug is preferred over libxmp (but this may need changing # in the future) cmake -S .. -B . $PG_BASE_CMAKE_FLAGS \ -DSDL2MIXER_DEPS_SHARED=0 -DSDL2MIXER_VENDORED=0 \ - -DSDL2MIXER_FLAC_LIBFLAC=1 -DSDL2MIXER_FLAC_DRFLAC=0 \ -DSDL2MIXER_MOD_MODPLUG=1 -DSDL2MIXER_MOD_XMP=0 \ -DSDL2MIXER_MP3_MPG123=1 -DSDL2MIXER_MP3_DRMP3=0 \ -DSDL2MIXER_VORBIS=VORBISFILE -DSDL2MIXER_VORBIS_VORBISFILE_SHARED=0 \