From 0584ce530d41e9a10e6e901410844480d069f835 Mon Sep 17 00:00:00 2001 From: Matthias Fey Date: Wed, 20 Mar 2024 20:55:33 +0100 Subject: [PATCH] Add macOS M1 support (#310) --- .github/workflows/building.yml | 23 ++++++++++------------- .github/workflows/nightly.yml | 17 ++++++++++++++++- CHANGELOG.md | 1 + 3 files changed, 27 insertions(+), 14 deletions(-) diff --git a/.github/workflows/building.yml b/.github/workflows/building.yml index dc4c15b62..65ea31698 100644 --- a/.github/workflows/building.yml +++ b/.github/workflows/building.yml @@ -10,7 +10,7 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-20.04, macos-11, windows-2019] + os: [ubuntu-20.04, macos-14, windows-2019] python-version: ['3.8', '3.9', '3.10', '3.11', '3.12'] torch-version: [1.12.0, 1.13.0, 2.0.0, 2.1.0, 2.2.0] cuda-version: ['cpu', 'cu113', 'cu116', 'cu117', 'cu118', 'cu121'] @@ -58,23 +58,20 @@ jobs: cuda-version: 'cu116' - torch-version: 2.2.0 cuda-version: 'cu117' - - os: macos-11 + - os: macos-14 cuda-version: 'cu113' - - os: macos-11 + - os: macos-14 cuda-version: 'cu116' - - os: macos-11 + - os: macos-14 cuda-version: 'cu117' - - os: macos-11 + - os: macos-14 cuda-version: 'cu118' - - os: macos-11 + - os: macos-14 cuda-version: 'cu121' - # Fails with: - # * note: 'value' has been explicitly marked unavailable here - # * error: 'value' is unavailable: introduced in macOS 10.13 - - os: macos-11 - python-version: '3.11' - - os: macos-11 - python-version: '3.12' + - os: macos-14 + python-version: '3.8' + - os: macos-14 + python-version: '3.9' steps: - name: Checkout repository diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index ccbe7b18b..1eef0b3b8 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -14,11 +14,12 @@ jobs: strategy: fail-fast: false matrix: - os: [ubuntu-20.04] + os: [ubuntu-20.04, macos-14, windows-2019] python-version: ['3.8', '3.9', '3.10', '3.11', '3.12'] torch-version: [1.12.0, 1.13.0, 2.0.0, 2.1.0, 2.2.0] cuda-version: ['cpu', 'cu113', 'cu116', 'cu117', 'cu118', 'cu121'] exclude: + - os: windows-2019 # No windows support yet :( - torch-version: 1.12.0 python-version: '3.12' - torch-version: 1.13.0 @@ -61,6 +62,20 @@ jobs: cuda-version: 'cu116' - torch-version: 2.2.0 cuda-version: 'cu117' + - os: macos-14 + cuda-version: 'cu113' + - os: macos-14 + cuda-version: 'cu116' + - os: macos-14 + cuda-version: 'cu117' + - os: macos-14 + cuda-version: 'cu118' + - os: macos-14 + cuda-version: 'cu121' + - os: macos-14 + python-version: '3.8' + - os: macos-14 + python-version: '3.9' steps: - name: Checkout repository diff --git a/CHANGELOG.md b/CHANGELOG.md index 122c4106f..4c8a5e97c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/). ## [0.5.0] - 2023-MM-DD ### Added +- Added macOS Apple Silicon support ([#310](https://github.com/pyg-team/pyg-lib/pull/310)) ### Changed ### Removed