Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old pyfa-experimental #4

Open
blitzmann opened this issue Oct 10, 2016 · 2 comments
Open

Old pyfa-experimental #4

blitzmann opened this issue Oct 10, 2016 · 2 comments

Comments

@blitzmann
Copy link
Contributor

blitzmann commented Oct 10, 2016

c&p from Slack

btw, totally forgot this was a thing

https://github.com/DarkFenX/pyfa-experimental

It probably isn't of much use anymore. This was when we were going to go forward with wxPython and whatnot but I believe Kadesh started integrating eos with other things

He had the concept of EOS data manager and pyfa data manager. He also started to support 'commands' which were actions that could be reversed (so, undo/redo functionality)

I don't know much about it, and don't know if the concepts translate well to a client/server architecture anymore, but it might be beneficial to poke around at it and see if there's anything we can use going forward

Looking at it very quickly, there seems to be a lot that we can do with it potentially. It pretty much ties in EOS data with pyfa-specific data. As we know, EOS only works with numbers. So there isn't any real text. EOS doesn't know what the module name is, or the attribute names. However, Kadesh worked it in to seamlessly integrate a pyfa data model (what we're used to - fit is a Fit object, has a Ship property that points to an EVE Item wrapper and include name, attributes, blah blah blah) with the EOS data model (numbers and calculations and stats)

This is something we're going to have to delve into and see if there's anything in here tat can be salvaged / utilized. It might be extremely helpful to get us off the ground as it already lays out a format for how we integrate EOS stats and calculations with (user-facing) pyfa data models.

@DarkFenX
Copy link
Member

It is 'skeleton' for purely offline fitting tool. I do not plan to abandon it. UI might be not necessary wx, it might be QT or anything else.

Let's just shelve it for now and take a look later. I know too little about pyfa-ng planned architecture, features and similar stuff.

@Ebag333
Copy link
Collaborator

Ebag333 commented Oct 15, 2016

I haven't looked at this yet, but it sounds pretty close to perfect.

We need a framework to handle our DB connection, pyCrest, feed data to Flask, run conversions, etc. Eos doesn't (and shouldn't) know about these things.

I'll poke around this some and see what it looks like. We'll have to modify it to handle Eos as a module, but that should be fairly straightforward. At the very least, there should be good chunks of code we can reuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants