-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a JS minifier Step #37
Comments
https://github.com/tdewolff/minify is built in Go but comes with Python bindings, but lacks wheels in its CI. Best play may be to make a pull request to add wheels, since the repository is actively maintained. |
Another option could be to make PyO3 bindings to https://github.com/swc-project/swc; however, this project is much broader than our need, and could be a huge challenge to wrap for our needs. |
See tdewolff/minify#599 and tdewolff/minify#600. Looks like Golang is very difficult to bind to Python, so may consider working on swc bindings with maturin. |
SWC is about 10x slower than tdewolff-minify and produces about 1% smaller output. |
We should be able to move forward with tdewolff-minify; though wheels won't be available for every platform, the most important by far will be covered along with several others. Mac users may need to use Docker or a VM as a workaround. |
Add AssetMinifierStep, using tdewolff-minify (#37)
Right now we don't have any minifiers for JavaScript.
minify-html
comes withminify-js
, butminify-js
is known to have correctness issues: https://github.com/privatenumber/minification-benchmarks.The text was updated successfully, but these errors were encountered: