Remove filters for warnings from argmin/argmax from tests

Pass an explicit axis or dim argument instead to avoid the warning.

Author: johnomotani

xarray/tests/test_units.py

@@ -1408,8 +1408,8 @@ def test_real_and_imag(self):
         (
             method("all"),
             method("any"),
-            method("argmax"),
-            method("argmin"),
+            method("argmax", axis=0),
+            method("argmin", axis=0),
             method("argsort"),
             method("cumprod"),
             method("cumsum"),
@@ -1427,9 +1427,6 @@ def test_real_and_imag(self):
         ),
         ids=repr,
     )
-    @pytest.mark.filterwarnings(
-        "ignore:Behaviour of argmin/argmax with neither dim nor :DeprecationWarning"
-    )
     def test_aggregation(self, func, dtype):
         array = np.linspace(0, 1, 10).astype(dtype) * (
             unit_registry.m if func.name != "cumprod" else unit_registry.dimensionless
@@ -2280,8 +2277,8 @@ def test_repr(self, func, variant, dtype):
             function("cumprod"),
             method("all"),
             method("any"),
-            method("argmax"),
-            method("argmin"),
+            method("argmax", axis=0),
+            method("argmin", axis=0),
             method("max"),
             method("mean"),
             method("median"),
@@ -2298,9 +2295,6 @@ def test_repr(self, func, variant, dtype):
         ),
         ids=repr,
     )
-    @pytest.mark.filterwarnings(
-        "ignore:Behaviour of argmin/argmax with neither dim nor :DeprecationWarning"
-    )
     def test_aggregation(self, func, dtype):
         array = np.arange(10).astype(dtype) * (
             unit_registry.m if func.name != "cumprod" else unit_registry.dimensionless
@@ -3853,8 +3847,8 @@ def test_repr(self, func, variant, dtype):
             function("cumprod"),
             method("all"),
             method("any"),
-            method("argmax"),
-            method("argmin"),
+            method("argmax", axis=0),
+            method("argmin", axis=0),
             method("max"),
             method("min"),
             method("mean"),
@@ -3871,12 +3865,6 @@ def test_repr(self, func, variant, dtype):
         ),
         ids=repr,
     )
-    @pytest.mark.filterwarnings(
-        "ignore:Once the behaviour of DataArray:DeprecationWarning"
-    )
-    @pytest.mark.filterwarnings(
-        "ignore:Behaviour of argmin/argmax with neither dim nor :DeprecationWarning"
-    )
     def test_aggregation(self, func, dtype):
         unit_a, unit_b = (
             (unit_registry.Pa, unit_registry.degK)

xarray/tests/test_variable.py

@@ -1639,9 +1639,6 @@ def test_big_endian_reduce(self):
         expected = Variable([], 5)
         assert_identical(expected, v.sum())
 
-    @pytest.mark.filterwarnings(
-        "ignore:Behaviour of argmin/argmax with neither dim nor :DeprecationWarning"
-    )
     def test_reduce_funcs(self):
         v = Variable("x", np.array([1, np.nan, 2, 3]))
         assert_identical(v.mean(), Variable([], 2))
@@ -1660,7 +1657,7 @@ def test_reduce_funcs(self):
         assert_identical(v.all(dim="x"), Variable([], False))
 
         v = Variable("t", pd.date_range("2000-01-01", periods=3))
-        assert v.argmax(skipna=True) == 2
+        assert v.argmax(skipna=True, dim="t") == 2
 
         assert_identical(v.max(), Variable([], pd.Timestamp("2000-01-03")))