Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling of the tables #16

Closed
jorisvandenbossche opened this issue Sep 9, 2019 · 6 comments
Closed

Fix styling of the tables #16

jorisvandenbossche opened this issue Sep 9, 2019 · 6 comments

Comments

@jorisvandenbossche
Copy link
Member

See eg https://dev.pandas.io/pandas-sphinx-theme/reference/io.html

We might need to remove some old custom styling (from nature), and ensure that bootstrap's tables are used. But those might again require some styling to fit for autosummary tables etc

@jorisvandenbossche
Copy link
Member Author

So the normal tables are fine (and now look good as bootstrap tables after #21), but the autosummary generated tables have some problems:

image

(https://dev.pandas.io/docs/reference/frame.html)

The problem is in autosummary defining a colgroup in the generated html:

<table class="longtable table">
  <colgroup>
    <col style="width: 10%">
    <col style="width: 90%">
  </colgroup>
  <tbody>
...

and for some reason all existing sphinx themes I looked at handle this fine (basically ignore it?), but bootstrap wants to follow it (although it also expands somewhat when needed, because sometimes it is more than 10%, see picture above).

@jreback
Copy link

jreback commented Oct 4, 2019

random issue here: https://dev.pandas.io/docs/user_guide/reshaping.html

pivoting with single aggregations (table not rendering in the note)

@jorisvandenbossche
Copy link
Member Author

@jreback that's broken in the old docs as well (https://pandas.pydata.org/pandas-docs/stable/user_guide/reshaping.html#pivoting-with-single-aggregations), so probably rather an issue with the rst formatting. Will open an issue on the pandas side.

@jorisvandenbossche
Copy link
Member Author

From #27: we might want to have "striped" tables as a default. Either we add some css to apply that to all tables, or we can ensure in the rst to add the table-striped class.

@12rambau
Copy link
Collaborator

12rambau commented Jun 4, 2022

This is an old issue, the current table display looks like this:

Capture d’écran 2022-06-04 à 09 26 39

Do you still think that having them striped is necessary?

@choldgraf
Copy link
Collaborator

In my opinion, we can close this one and re-open a new one if somebody else reports a problem, since the style has changed a decent amount

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants