Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluate global_dict argument ignored #497

Open
gdementen opened this issue Sep 4, 2024 · 2 comments
Open

evaluate global_dict argument ignored #497

gdementen opened this issue Sep 4, 2024 · 2 comments
Labels

Comments

@gdementen
Copy link
Contributor

>>> ne.evaluate('a', local_dict={'a': 1})
array(1, dtype=int32)
>>> ne.evaluate('a', global_dict={'a': 1})
KeyError: 'a'

The problem is a regression introduced in 21ff376 because global_dict is not passed to re_evaluate (which does not support global_dict either)

@FrancescAlted
Copy link
Contributor

Ok, so global_dict is not honored since that commit (May 23, 2023)? That probably means that not many people use it. Maybe should we deprecate it; or do you think there is some use for it? If so, a PR would be appreciated.

gdementen added a commit to liam2/liam2 that referenced this issue Sep 6, 2024
Copy link

github-actions bot commented Nov 5, 2024

Message to comment on stale issues. If none provided, will not mark issues stale

@github-actions github-actions bot added the Stale label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants