-
-
Notifications
You must be signed in to change notification settings - Fork 83
Add AWS SSM Parameter Store support #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
seems @ceb10n has also worked on an extension for this recently, supporting blog post (with some use cases)
|
But although I developed the If someday people start using these features a lot, maybe it will make more sense to add it, but before that, I agree that it would bring some unnecessary complexity to the code base. But if the project decides to add it the future, I'll be glad to help ;) |
We added AWS secret manager support. The PR is merged but still hasn't been released. |
@hramezani What does that mean for this issue? #385 could be reopened if we want to additionally support AWS Parameter Store (I'm curious how AWS Secret Manager got buy-in). |
@alukach there were some requests for AWS secret manager and it seems people are using it a lot. |
In #385, I added a code change to natively support retrieving configuration from the AWS Systems Manager Parameter Store. However, that was somewhat premature as support for such a feature had not yet been agreed upon.
This issue is to track support for that feature.
Background
From the product page:
It is similar to AWS Secrets Manager, with a few differences:
/app/prod/db/username
and/app/prod/db/password
could mape well todb: DbSettings
)Fit within Pydantic Settings
Given that we currently support Azure Key Vault settings source (#272) and have green-lighted support for AWS Secrets Manager (#175 (comment)), I think rounding out support with AWS SSM Parameter Store seems like a reasonable addition.
Will people use it?
I maintain a project to support for AWS SSM Parameter Store for Pydantic v1 (github, pypi). At time of writing, it has 19 stars on Github and PyPi stats reports the usage as such:
Not tremendously popular, but it is used by projects in the wild.
The text was updated successfully, but these errors were encountered: