Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pystring_fast_new should probably be an unsafe fn #177

Open
davidhewitt opened this issue Dec 2, 2024 · 0 comments
Open

pystring_fast_new should probably be an unsafe fn #177

davidhewitt opened this issue Dec 2, 2024 · 0 comments

Comments

@davidhewitt
Copy link
Collaborator

The is_ascii parameter to pystring_fast_new is used to skip encoding utf8 properly and could lead to nasty data corruption if the string actually is not ascii. This should almost certainly be unsafe fn given users have to uphold the invariant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant