Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review] Test package #5

Open
2 tasks done
xuanxu opened this issue Mar 12, 2024 · 6 comments
Open
2 tasks done

[Review] Test package #5

xuanxu opened this issue Mar 12, 2024 · 6 comments
Labels
0/pre-review-checks If the package is in a pre-review stage with checks run by the EiC (or editor in some cases)

Comments

@xuanxu
Copy link
Member

xuanxu commented Mar 12, 2024

Submitting Author: J (@xuanxu)
All current maintainers:
Package Name: Test package
One-Line Description of Package: A simple test package
Repository Link: https://github.com/pyOpenSci/test-pyos-review/
Version submitted: 2.3.1
Editor: TBD
Reviewers:
Archive: TBD
JOSS DOI: TBD
Version accepted: TBD
Date accepted (month/day/year): TBD


Code of Conduct & Commitment to Maintain Package

  • I agree to abide by [pyOpenSci's Code of Conduct][PyOpenSciCodeOfConduct] during the review process and in maintaining my package after should it be accepted.
  • I have read and will commit to package maintenance after the review as per the [pyOpenSci Policies Guidelines][Commitment].
@xuanxu xuanxu added the New Submission! new pyos submission label Mar 12, 2024
@pyosbot
Copy link
Collaborator

pyosbot commented Mar 12, 2024

Hey @xuanxu 👋 welcome to pyOpenSci’s scientific Python peer review process!

We’ve seen your message. Someone from our editorial team will get back to you within the next week about this submission.
In the meantime, feel free to check out our packaging guide or feel free to ask questions on our Discourse forum.

@xuanxu
Copy link
Member Author

xuanxu commented Mar 12, 2024

@pyosbot assign eic

@pyosbot
Copy link
Collaborator

pyosbot commented Mar 12, 2024

I'm sorry @xuanxu, I'm afraid I can't do that. That's something only editors are allowed to do.

@lwasser
Copy link
Member

lwasser commented Mar 14, 2024

argh @xuanxu i thought i had added you but i think i didn't hit "add" on the last step of the process. i just added you and your name is now in our editorial team list. so this should work for you. This was my mistake

@lwasser
Copy link
Member

lwasser commented Mar 14, 2024

@pyosbot assign eic

@pyosbot
Copy link
Collaborator

pyosbot commented Mar 14, 2024

Editor in Chief checks

Hi there! Thank you for submitting your package for pyOpenSci
review. Below are the basic checks that your package needs to pass
to begin our review. If some of these are missing, we will ask you
to work on them before the review process begins.

Please check our Python packaging guide for more information on the elements
below.

  • Installation The package can be installed from a community repository such as PyPI (preferred), and/or a community channel on conda (e.g. conda-forge, bioconda).
    • The package imports properly into a standard Python environment import package.
  • Fit The package meets criteria for fit and overlap.
  • Documentation The package has sufficient online documentation to allow us to evaluate package function and scope without installing the package. This includes:
    • User-facing documentation that overviews how to install and start using the package.
    • Short tutorials that help a user understand how to use the package and what it can do for them.
    • API documentation (documentation for your code's functions, classes, methods and attributes): this includes clearly written docstrings with variables defined using a standard docstring format.
  • Core GitHub repository Files
    • README The package has a README.md file with clear explanation of what the package does, instructions on how to install it, and a link to development instructions.
    • Contributing File The package has a CONTRIBUTING.md file that details how to install and contribute to the package.
    • Code of Conduct The package has a CODE_OF_CONDUCT.md file.
    • License The package has an OSI approved license.
      NOTE: We prefer that you have development instructions in your documentation too.
  • Issue Submission Documentation All of the information is filled out in the YAML header of the issue (located at the top of the issue template).
  • Automated tests Package has a testing suite and is tested via a Continuous Integration service.
  • Repository The repository link resolves correctly.
  • Package overlap The package doesn't entirely overlap with the functionality of other packages that have already been submitted to pyOpenSci.
  • Archive (JOSS only, may be post-review): The repository DOI resolves correctly.
  • Version (JOSS only, may be post-review): Does the release version given match the GitHub release (v1.0.0)?

  • Initial onboarding survey was filled out
    We appreciate each maintainer of the package filling out this survey individually. 🙌
    Thank you authors in advance for setting aside five to ten minutes to do this. It truly helps our organization. 🙌


Editor comments

@pyosbot pyosbot added 0/pre-review-checks If the package is in a pre-review stage with checks run by the EiC (or editor in some cases) and removed New Submission! new pyos submission labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0/pre-review-checks If the package is in a pre-review stage with checks run by the EiC (or editor in some cases)
Projects
None yet
Development

No branches or pull requests

3 participants