Skip to content

Commit 39b992e

Browse files
committed
rebase 2
1 parent af04a91 commit 39b992e

File tree

6 files changed

+194
-158
lines changed

6 files changed

+194
-158
lines changed

_static/pyos.css

Lines changed: 20 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,18 @@
1-
--font-stack: -apple-system, BlinkMacSystemFont, Segoe UI, Helvetica, Arial,
2-
sans-serif, Apple Color Emoji, Segoe UI Emoji;
31

42
body, p {
5-
font-family: 'Segoe UI', Tahoma, Geneva, Verdana, sans-serif;
3+
font-size: 1.04em;
64
}
75

86
h1, h2, h3 {
9-
font-family:'Franklin Gothic Medium', 'Arial Narrow', Arial, sans-serif;
7+
font-family:'Franklin Gothic Medium', Arial, sans-serif;
108
font-weight: bold;
119
}
10+
11+
h1 {
12+
margin-bottom: 1em;
13+
font-size: 2.5rem;
14+
}
15+
1216
h2 {
1317
margin-top: 1.7em;
1418
}
@@ -17,7 +21,18 @@ h3, .content-container h3 {
1721
margin-top: 1.6em!important;
1822
}
1923

20-
/* HEADER BLOCK */
24+
ul li p {
25+
padding-bottom: .8em;
26+
line-height: 1.5em;
27+
}
28+
29+
.epigraph {
30+
font-style: italic;
31+
border-left: 4px solid #ccc!important;
32+
margin-left: 0!important;
33+
font-size: 1.2em!important;
34+
}
35+
2136
div.header__block {
2237
color: #222;
2338
}
@@ -37,37 +52,9 @@ div.header__block {
3752
background-color:#ccc;
3853
}
3954

40-
div .announcement .header-item .noprint, header-item.announcement {
41-
background-color: #ccc!important;
42-
} */
43-
44-
/* notes */
4555
div.admonition.note {
4656
margin-top: 4em;
4757
margin-bottom: 4em;
4858
background-color: #F8F9FB
4959
}
5060

51-
div.admonition.note .admonition-title, div.admonition.note .admonition-title::before {
52-
53-
}
54-
55-
/* div.admonition.note {
56-
border-color: #C1CFD4;
57-
background-color: #E3F4FA;
58-
} */
59-
60-
/* div.admonition.important .admonition-title, div.admonition.important .admonition-title::before {
61-
background-color: #107762;
62-
color: #ffffff!important;
63-
} */
64-
65-
/* div.admonition.important .admonition-title {
66-
background-color: #107762;
67-
border-color: #1abc9c;
68-
} */
69-
70-
/* div.admonition.important {
71-
border-color: #0e6654;
72-
background-color: #ecfcf9;
73-
} */

appendices/review-template.md

Lines changed: 81 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
1+
## Peer Review Template
2+
3+
```
4+
## Package Review
5+
6+
*Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide*
7+
8+
- [ ] As the reviewer I confirm that there are no conflicts of interest for me to review this work (If you are unsure whether you are in conflict, please speak to your editor _before_ starting your review).
9+
10+
#### Documentation
11+
12+
The package includes all the following forms of documentation:
13+
14+
- [ ] **A statement of need** clearly stating problems the software is designed to solve and its target audience in README
15+
- [ ] **Installation instructions:** for the development version of package and any non-standard dependencies in README
16+
- [ ] **Vignette(s)** demonstrating major functionality that runs successfully locally
17+
- [ ] **Function Documentation:** for all user-facing functions
18+
- [ ] **Examples** for all user-facing functions
19+
- [ ] **Community guidelines** including contribution guidelines in the README or CONTRIBUTING.
20+
- [ ] **Metadata** including author(s), author e-mail(s), a url, and any other relevant metadata e.g., in a `setup.py` file or elsewhere.
21+
22+
Readme requirements
23+
The package meets the readme requirements below:
24+
25+
- [ ] Package has a README.md file in the root directory.
26+
27+
The README should include, from top to bottom:
28+
29+
- [ ] The package name
30+
- [ ] Badges for continuous integration and test coverage, a repostatus.org badge, and any other badges. If the README has many more badges, you might want to consider using a table for badges: [see this example](https://github.com/ropensci/drake). Such a table should be more wide than high. (Note that the badge for pyOpenSci peer-review will be provided upon acceptance.)
31+
- [ ] Short description of goals of package, with descriptive links to all vignettes (rendered, i.e. readable, cf the documentation website section) unless the package is small and there’s only one vignette repeating the README.
32+
- [ ] Installation instructions
33+
- [ ] Any additional setup required (authentication tokens, etc)
34+
- [ ] Brief demonstration usage
35+
- [ ] Direction to more detailed documentation (e.g. your documentation files or website).
36+
- [ ] If applicable, how the package compares to other similar packages and/or how it relates to other packages
37+
- [ ] Citation information
38+
39+
#### Usability
40+
Reviewers are encouraged to submit suggestions (or pull requests) that will improve the usability of the package as a whole.
41+
Package structure should follow general community best-practices. In general please consider:
42+
43+
- [ ] The documentation is easy to find and understand
44+
- [ ] The need for the package is clear
45+
- [ ] All functions have documentation and associated examples for use
46+
47+
48+
#### Functionality
49+
50+
- [ ] **Installation:** Installation succeeds as documented.
51+
- [ ] **Functionality:** Any functional claims of the software been confirmed.
52+
- [ ] **Performance:** Any performance claims of the software been confirmed.
53+
- [ ] **Automated tests:** Tests cover essential functions of the package and a reasonable range of inputs and conditions. All tests pass on the local machine.
54+
- [ ] **Continuous Integration:** Has continuous integration, such as Travis CI, AppVeyor, CircleCI, and/or others.
55+
- [ ] **Packaging guidelines**: The package conforms to the pyOpenSci [packaging guidelines](https://www.pyopensci.org/contributing-guide/authoring/index.html#packaging-guide).
56+
57+
#### For packages co-submitting to JOSS
58+
59+
- [ ] The package has an **obvious research application** according to JOSS's definition in their [submission requirements](http://joss.theoj.org/about#submission_requirements).
60+
61+
*Note:* Be sure to check this carefully, as JOSS's submission requirements and scope differ from pyOpenSci's in terms of what types of packages are accepted.
62+
63+
The package contains a `paper.md` matching [JOSS's requirements](http://joss.theoj.org/about#paper_structure) with:
64+
65+
- [ ] **A short summary** describing the high-level functionality of the software
66+
- [ ] **Authors:** A list of authors with their affiliations
67+
- [ ] **A statement of need** clearly stating problems the software is designed to solve and its target audience.
68+
- [ ] **References:** with DOIs for all those that have one (e.g. papers, datasets, software).
69+
70+
#### Final approval (post-review)
71+
72+
- [ ] **The author has responded to my review and made changes to my satisfaction. I recommend approving this package.**
73+
74+
Estimated hours spent reviewing:
75+
76+
---
77+
78+
#### Review Comments
79+
80+
81+
```

appendices/templates.md

Lines changed: 1 addition & 79 deletions
Original file line numberDiff line numberDiff line change
@@ -24,86 +24,8 @@ Reviewers:
2424
Due date:
2525
```
2626

27-
## Review Template
28-
29-
```
30-
## Package Review
31-
32-
*Please check off boxes as applicable, and elaborate in comments below. Your review is not limited to these topics, as described in the reviewer guide*
33-
34-
- [ ] As the reviewer I confirm that there are no conflicts of interest for me to review this work (If you are unsure whether you are in conflict, please speak to your editor _before_ starting your review).
35-
36-
#### Documentation
37-
38-
The package includes all the following forms of documentation:
39-
40-
- [ ] **A statement of need** clearly stating problems the software is designed to solve and its target audience in README
41-
- [ ] **Installation instructions:** for the development version of package and any non-standard dependencies in README
42-
- [ ] **Vignette(s)** demonstrating major functionality that runs successfully locally
43-
- [ ] **Function Documentation:** for all user-facing functions
44-
- [ ] **Examples** for all user-facing functions
45-
- [ ] **Community guidelines** including contribution guidelines in the README or CONTRIBUTING.
46-
- [ ] **Metadata** including author(s), author e-mail(s), a url, and any other relevant metadata e.g., in a `setup.py` file or elsewhere.
47-
48-
Readme requirements
49-
The package meets the readme requirements below:
50-
51-
- [ ] Package has a README.md file in the root directory.
52-
53-
The README should include, from top to bottom:
54-
55-
- [ ] The package name
56-
- [ ] Badges for continuous integration and test coverage, a repostatus.org badge, and any other badges. If the README has many more badges, you might want to consider using a table for badges: [see this example](https://github.com/ropensci/drake). Such a table should be more wide than high. (Note that the badge for pyOpenSci peer-review will be provided upon acceptance.)
57-
- [ ] Short description of goals of package, with descriptive links to all vignettes (rendered, i.e. readable, cf the documentation website section) unless the package is small and there’s only one vignette repeating the README.
58-
- [ ] Installation instructions
59-
- [ ] Any additional setup required (authentication tokens, etc)
60-
- [ ] Brief demonstration usage
61-
- [ ] Direction to more detailed documentation (e.g. your documentation files or website).
62-
- [ ] If applicable, how the package compares to other similar packages and/or how it relates to other packages
63-
- [ ] Citation information
64-
65-
#### Usability
66-
Reviewers are encouraged to submit suggestions (or pull requests) that will improve the usability of the package as a whole.
67-
Package structure should follow general community best-practices. In general please consider:
68-
69-
- [ ] The documentation is easy to find and understand
70-
- [ ] The need for the package is clear
71-
- [ ] All functions have documentation and associated examples for use
72-
73-
74-
#### Functionality
75-
76-
- [ ] **Installation:** Installation succeeds as documented.
77-
- [ ] **Functionality:** Any functional claims of the software been confirmed.
78-
- [ ] **Performance:** Any performance claims of the software been confirmed.
79-
- [ ] **Automated tests:** Tests cover essential functions of the package and a reasonable range of inputs and conditions. All tests pass on the local machine.
80-
- [ ] **Continuous Integration:** Has continuous integration, such as Travis CI, AppVeyor, CircleCI, and/or others.
81-
- [ ] **Packaging guidelines**: The package conforms to the pyOpenSci [packaging guidelines](https://www.pyopensci.org/contributing-guide/authoring/index.html#packaging-guide).
82-
83-
#### For packages co-submitting to JOSS
84-
85-
- [ ] The package has an **obvious research application** according to JOSS's definition in their [submission requirements](http://joss.theoj.org/about#submission_requirements).
86-
87-
*Note:* Be sure to check this carefully, as JOSS's submission requirements and scope differ from pyOpenSci's in terms of what types of packages are accepted.
88-
89-
The package contains a `paper.md` matching [JOSS's requirements](http://joss.theoj.org/about#paper_structure) with:
90-
91-
- [ ] **A short summary** describing the high-level functionality of the software
92-
- [ ] **Authors:** A list of authors with their affiliations
93-
- [ ] **A statement of need** clearly stating problems the software is designed to solve and its target audience.
94-
- [ ] **References:** with DOIs for all those that have one (e.g. papers, datasets, software).
95-
96-
#### Final approval (post-review)
97-
98-
- [ ] **The author has responded to my review and made changes to my satisfaction. I recommend approving this package.**
99-
100-
Estimated hours spent reviewing:
101-
102-
---
103-
104-
#### Review Comments
105-
10627

28+
```{include} review-template.md
10729
```
10830

10931
## Review Request Template

conf.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
"sphinx.ext.intersphinx",
3737
"sphinx_sitemap",
3838
"sphinxext.opengraph",
39+
"sphinx_copybutton",
3940
]
4041

4142
# colon fence for card support in md
@@ -56,8 +57,6 @@
5657
"announcement": "🚧 UNDER CONSTRUCTION: this guide is under heavy construction right now. 🚧"
5758
}
5859

59-
60-
6160
# Add any paths that contain templates here, relative to this directory.
6261
templates_path = ['_templates']
6362

software-peer-review-guide/author-guide.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,9 +178,9 @@ in advance. We will try to help you either.
178178
* Find a new maintainer to take over your project (or additional maintainers to support maintenance) or
179179
* Sunset your package.
180180

181-
If the package is sunsetted we will remove it from our curated list
181+
If the package is sunsetted, we will remove it from our curated list
182182
of vetted tools.
183183

184184
### Communication with pyOpenSci and removing tools from our vetted tool list
185185

186-
To ensure packages that we support and advocate for are maintained, if your package is accepted and we are not able to get in touch with you through normal communication channels (GitHub, email) after reaching our for atleast 1-2 months, we will remove your package from our list of vetted tools. We will also sunset any blogs written that highlight your tool.
186+
To ensure packages that we support and advocate for are maintained, if your package is accepted and we are not able to get in touch with you through normal communication channels (GitHub, email) after reaching our for atleast 1-2 months, we will remove your package from our list of vetted tools. We will also deprecate any blogs written that highlight your tool.

0 commit comments

Comments
 (0)