Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: pdfly x2pdf --layout #64

Open
Lucas-C opened this issue Oct 29, 2024 · 5 comments · May be fixed by #67
Open

ENH: pdfly x2pdf --layout #64

Lucas-C opened this issue Oct 29, 2024 · 5 comments · May be fixed by #67

Comments

@Lucas-C
Copy link
Member

Lucas-C commented Oct 29, 2024

The new --layout parameter would allow the following values:

  • 2x2 : meaning to combine input files on every page of the output PDF document so that it forms a grid of 2 columns & 2 rows ( this is similar to https://github.com/pmaupin/pdfrw/blob/master/examples/4up.py )
  • 3x3 : same, with a grid of 3 columns & 3 rows
  • 1x2 : same, with a grid of 1 column & 2 rows
  • 2x1 : same, with a grid of 2 columns & 1 row
@mulla028
Copy link

Hello! I would like to help you with this issue! Please assign me

@Lucas-C
Copy link
Member Author

Lucas-C commented Oct 30, 2024

Hello! I would like to help you with this issue! Please assign me

Hi @mulla028
Are you willing to work on both this issue and #63 at the same time?
It may be better to tackle them one after the other 🙂

@mulla028
Copy link

Hello! I would like to help you with this issue! Please assign me

Hi @mulla028

Are you willing to work on both this issue and #63 at the same time?

It may be better to tackle them one after the other 🙂

I have already opened a PR for issue #63, waiting for your review. I also started working on this one.

@mulla028
Copy link

mulla028 commented Oct 30, 2024

Hello! I would like to help you with this issue! Please assign me

Hi @mulla028

Are you willing to work on both this issue and #63 at the same time?

It may be better to tackle them one after the other 🙂

@Lucas-C for these two issues (#63 & #64) I am opening two separate PRs.

@Lucas-C
Copy link
Member Author

Lucas-C commented Oct 30, 2024

@Lucas-C for these two issues (#63 & #64) I am opening two separate PRs.

Alright, go on then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants