-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin Flow? #368
Comments
Hi @ychescale9 and thanks for your extensive feedback!
I used this name to indicate that library is using ReactiveExtensions and ReactiveStreams. There are other libraries with Reactive name prefix, which uses RxJava. I heard about similar projects called RxNetwork, etc. As long as I as own package name
That's good idea!
Right now, RxJava is tightly coupled to this library and project heavily relies on it. I think, starting a new repo and keeping this project as a reference with ideas for development would be the best option. Coroutines are slightly different concept than reactive programming. Moreover, coroutines are available in Kotlin only and this project provides support both for Java and Kotlin users. When I find some time, I consider preparing project like that, because it'd be interesting to develop it, but I cannot promise any specific release dates, etc.
Great to hear that you find it useful! Thanks! :) |
Thanks @pwittchen that all makes sense. In that case I'd like to take a shot at porting ReactiveNetwork to Flow in a new repo. Will ping you for feedback / insight if you're cool with this 😄 |
Sure :) |
@ychescale9 did you manage to do porting? Or maybe did you find any existing analogues based on Kotlin Flow? |
I haven’t found the time to do it yet but hoping to get to it soon. I’ll probably do a prototype here and then move it to a proper library later. |
@ychescale9 @pwittchen I've made a port by myself: https://github.com/AndreySBer/FlowReactiveNetwork |
Great! Thanks for the update. |
Oh, guys I have also done the same port https://github.com/lion4ik/NetworkFlow |
@lion4ik thanks! Since there are a couple of alternatives now (and there’ll be more to come) I think we can close the issue now😀 |
Hi @pwittchen, now that Kotlin Coroutines Flow is stable, I'm wondering if there's any interest / plans to migrate the project to kotlin and expose
Flow
in the APIs (or just your thoughts in general).I'm aware that this is a RxJava project and you're also planning to support RxJava 3 so this might be out of scope for ReactiveNetwork. But there are a couple of reasons I still want to raise this issue:
A few options I have in mind:
Flow
type instead of RxObsersvable
Regardless of what you think about this I'm still extremely grateful for the work you've put into this great library.
The text was updated successfully, but these errors were encountered: