-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NSRDB GOES V4 #2326
Comments
I was unsure what to make of the GOES V4 datasets. The descriptions of the various GOES endpoints all seem to be generic “copy pasta” at https://developer.nrel.gov/docs/solar/nsrdb/. Perhaps this should be reported? |
Another source of information about these datasets is the NSRDB website, for example, https://nsrdb.nrel.gov/data-sets/us-data. There's no mention of GOES V4 there (yet), although the GOES V4 endpoints are included in the list of available data from the NSRDB Viewer, albeit with different names: |
Tagging @grantbuster, should there be updates to the docs on the NREL developer website for NSRDB GOES V4? I'll admit that I was expecting "PSM V4", so even the name has me a bit confused. Also, I thought about tagging Paul Edwards, but this seems like a question for the NSRD team instead of the developer website team, so I'll let someone else tag him if needed... |
To better follow semver and avoid surprising users when upgrading |
I recommend updating pvlib from PSM V3 to PSM V4. Enhancements in PSM V4 compared to PSM V3:
|
Does the NREL API parse that? pvlib is just passing the value of
The |
I can't seem to get a multi-year request to work. The documentation does make it seem like it should work, though. |
I think I was mistaken here. CSV-formatted responses apparently do not support multiple years:
From https://developer.nrel.gov/docs/solar/nsrdb/psm3-2-2-download/. |
@cwhanse So the idea is to grow this dictionary as the NSRDB evolves? |
Yes, and keep the current function's signature. |
@AdamRJensen @kandersolar @wholmgren, it looks like "horns" issue has been resolved with GOES v4. Add this to the "reasons to add GOES V4" bucket. To my eye, it looks like some variability has increased, but hard to say if it's "better". It looks worse for this one day, but there are other (more important, IMO) types of variable conditions that I haven't looked at. For reference (from https://doi.org/10.1109/PVSC57443.2024.10748762): |
I also just noticed that GOES V4 now includes 2023, while PSM3 is still only available through 2022. https://developer.nrel.gov/docs/solar/nsrdb/nsrdb-GOES-aggregated-v4-0-0-download/ vs https://developer.nrel.gov/docs/solar/nsrdb/psm3-2-2-download/. I'm speculating, but if the NSRDB team is not planning to update PSM3, then that makes adding GOES V4 a higher priority. I've sent an email to that team and will report back if I hear anything. |
I have stepped back from my role in the NSRDB project so I’m no longer a good resource for what’s going on with the latest and greatest… that being said, this has not been responded to in a while now so I’ll try to help. I’m pretty sure that new years of data will be released under NSRDB v4, and v3 will continue to be available on S3 but will not be maintained. |
In hindsight, I wish Function naming: I think |
Current endpoints are:
@kandersolar, are you suggesting 3 functions, like FYI, GOES4 endpoints not included (as of now in PR #2378):
|
I suppose so, although perhaps it is worth waiting for some thumbs up on the idea before putting effort towards code changes. |
As an aside on naming, "GOES v4" is confusing to me. Was version 3 PSM3? And GOES v4 is what would have been called PSM4, but it's now named after the satellites (GOES) instead of the "physical solar model" (PSM)? Here's an abstract from last month that references "PSM v4": https://ams.confex.com/ams/105ANNUAL/meetingapp.cgi/Paper/455074. I'm wondering if we are going to get comfortable with "GOES4" and then the NSRDB team will change it to "PSM4" or something... |
I read it as @williamhobbs does, "PSM v4" is the satellite-to-irradiance model, and "GOES" is the satellite data source (vs. e.g. Himawari). I would lean toward naming the pvlib functions Maybe the endpoint can be a parameter? |
I just saw a copy of the slides from AMS 2025 and it does seem that "PSM v4" is the name the NREL team is using. I'm convinced we should use "psm4" instead of "goes4" in the function name(s). |
I am also in favor of separate functions for separate end points. I'm neutral on if we should also maintain a |
As I understand it, the NREL team also processes data from other satellites for other regions and makes the results available under the NSRDB umbrella. I haven't checked, but there are probably different end points for those. Perhaps we should look at the whole list before deciding how to wrap them? I'm in favor of aiming for one-to-one io functions, but justified exceptions are ok. |
Is there a reason the |
Quick note: with NREL/developer.nrel.gov#377, the PSM3.2.2 endpoints are now marked as deprecated: https://developer.nrel.gov/docs/solar/nsrdb/ |
I think this is correct. And what's worse, different datasets (different spatial/time extents) can come from the same satellite. A full accounting for the GOES-based PSM4 datasets would look something like this:
I think I'd be in favor of us adding three functions at this time: We might also consider adding functions for the Meteosat (Europe/Africa/Middle East) and Himawari (East Asia/Australia) endpoints, but they do not seem to be updated with the latest data, so perhaps we should wait for the NSRDB team to show more interest in maintaining those datasets before we add functions for them. |
@kandersolar, I created a new branch with the 4 separate |
Just to further clarify or confuse: GOES isn't just one satellite (pair), but a series of satellites over time with evolving capabilities. I don't think there's a lack of interest at NREL, but it's just a huge task to do all they do. There is interest from the northern latitudes for |
I should have worded that sentence differently. I only meant that there's a lot of churn in the NSRDB world and I'm wary of adding functions for datasets that (for understandable reasons) won't get updated or might disappear entirely before too long. |
I guess this churn could be handled more easily or nimbly with a separate iotools package. |
I think I like this when looking at the functions. I like the opportunity to fix the awkwardness with |
NSRDB's latest "V4" dataset appears to be available. It would be nice to have this available in iotools.
See NREL/SAM#1920 for some additional info. Quoting @cpaulgilman:
Also note that there was an issue with DNI that has been fixed (also in that SAM issue's comments).
The text was updated successfully, but these errors were encountered: