Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite sheds beam fraction on ground zenith guardrail syntax bug #2245

Closed
mikofski opened this issue Oct 9, 2024 · 0 comments · Fixed by #2359
Closed

Infinite sheds beam fraction on ground zenith guardrail syntax bug #2245

mikofski opened this issue Oct 9, 2024 · 0 comments · Fixed by #2359
Labels
bug easy good first issue help wanted
Milestone
v0.11.3

Comments

@mikofski
Copy link
Member

mikofski commented Oct 9, 2024 •
edited
Loading

Describe the bug
As reported by @kdebrab in this #717 (review) comment

Expected behavior
the line is meant to start with f_gnd_beam = and clip it at max zenith so values don’t blow up.

Versions:

  • pvlib.__version__: <=0.11.1
@matsuobasho matsuobasho mentioned this issue Oct 16, 2024
Open
jason-rpkt added a commit to jason-rpkt/pvlib-python that referenced this issue Jan 23, 2025
@jason-rpkt
Issue pvlib#2245
62045a5 
Infinite sheds beam fraction on ground zenith
guardrail syntax bug
Set unshaded ground fraction to zero for
solar_zenith> max_zenith
@jason-rpkt jason-rpkt mentioned this issue Jan 23, 2025
Merged
8 tasks
@echedey-ls echedey-ls added this to the v0.11.3 milestone Jan 23, 2025
jason-rpkt added a commit to jason-rpkt/pvlib-python that referenced this issue Jan 24, 2025
@jason-rpkt
Issue pvlib#2245 - Linting/ PEP8
23dd57e
jason-rpkt added a commit to jason-rpkt/pvlib-python that referenced this issue Jan 24, 2025
@jason-rpkt
Issue pvlib#2245 utils.py
8b67a41 
Line 90 linter/ PEP8
jason-rpkt added a commit to jason-rpkt/pvlib-python that referenced this issue Jan 27, 2025
@jason-rpkt
Revert "Issue pvlib#2245 utils.py"
59d6581 
This reverts commit 8b67a41.
cwhanse added a commit that referenced this issue Feb 4, 2025
@jason-rpkt @cwhanse
Issue #2245 Infinite sheds beam fraction on ground zenith guardrail s…
2ca40aa 
…yntax bug (#2359)

* Issue #2245
Infinite sheds beam fraction on ground zenith
guardrail syntax bug
Set unshaded ground fraction to zero for
solar_zenith> max_zenith

* Issue #2245 - Linting/ PEP8

* Revert "Issue #2245 utils.py"

This reverts commit 8b67a41.

* Update from solar_zenith to ghi
Update docs\sphinx\source\whatsnew\v0.11.3.rst

* series input for ghi in test_infinite_sheds.py

* Update docs/sphinx/source/whatsnew/v0.11.3.rst

---------

Co-authored-by: Cliff Hansen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug easy good first issue help wanted
Projects
None yet
Milestone
v0.11.3
2 participants
@mikofski @echedey-ls