Skip to content

Commit

Permalink
edit the Note
Browse files Browse the repository at this point in the history
  • Loading branch information
cwhanse committed Jan 10, 2024
1 parent 34b3824 commit 7d59f98
Showing 1 changed file with 16 additions and 11 deletions.
27 changes: 16 additions & 11 deletions pvlib/pvarray.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,6 @@ def huld(effective_irradiance, temp_mod, pdc0, k=None, cell_type=None):
P_{dc} &= G' ( P_{dc0} + k_1 \log(G') + k_2 \log^2 (G') + k_3 T' +
k_4 T' \log(G') + k_5 T' \log^2 (G') + k_6 T'^2)
:label: main
G' &= \frac{G_{poa eff}}{1000}
Expand Down Expand Up @@ -287,11 +286,17 @@ def huld(effective_irradiance, temp_mod, pdc0, k=None, cell_type=None):
Notes
-----
Eq. :eq:`main` is from [1]_. The expression used in PVGIS documentation is
different, factoring :math:`P_{dc0}` out of the polynomial. PVGIS
documentation shows a table of default parameters :math:`k'` for different
cell types. The parameters :math:`k'` differ from the parameters expected
by :py:func:`huld` by the factor ``pdc0``, that is,
The equation for :math:`P_{dc}` is from [1]_. The expression used in PVGIS
documentation is differs by factoring :math:`P_{dc0}` out of the
polynomial:
..math::
P_{dc} = G' P_{dc0} (1 + k'_1 \log(G') + k'_2 \log^2 (G') + k''_3 T' +
k'_4 T' \log(G') + k'_5 T' \log^2 (G') + k'_6 T'^2)
PVGIS documentation shows a table of default parameters :math:`k'` for
different cell types. The parameters :math:`k'` differ from the parameters
:math:`k` expected by :py:func:`huld` by the factor ``pdc0``, that is,
.. math::
Expand All @@ -304,13 +309,13 @@ def huld(effective_irradiance, temp_mod, pdc0, k=None, cell_type=None):
- the Martin and Ruiz model for the incidence angle modifier (IAM)
:py:func:`pvlib.iam.martin_ruiz`
- a custom model for a spectral adjustment factor
The PVGIS API (see :py:func:`pvlib.iotools.pvgis.get_pvgis_hourly) returns
The PVGIS API (see :py:func:`pvlib.iotools.pvgis.get_pvgis_hourly`) returns
broadband plane-of-array irradiance (``poa_global``) and DC power (``P``).
``poa_global`` is irradiance before applying the IAM and spectral
adjustments, where as ``effective_irradiance`` input to :py:func:`huld`
should be after these adjustments are applied. Users comparing output of
:py:func:`huld` to PVGIS' ``P`` should expect differences unless
``effective_irradiance`` is computed the same way as done by PVGIS.
adjustments. In contrast the ``effective_irradiance`` for :py:func:`huld`
is after these adjustments are applied. Users comparing output of
:py:func:`huld` to PVGIS' ``P`` values should expect differences unless
``effective_irradiance`` is computed in the same way as done by PVGIS.
References
----------
Expand Down

0 comments on commit 7d59f98

Please sign in to comment.