Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pull request preview for DApp on Push SDK repo for uiweb and restapi package #1352

Open
rohitmalhotra1420 opened this issue Jun 13, 2024 · 0 comments
Open

Implement pull request preview for DApp on Push SDK repo for uiweb and restapi package #1352

rohitmalhotra1420 opened this issue Jun 13, 2024 · 0 comments
Assignees
@rohitmalhotra1420

Comments

@rohitmalhotra1420
Copy link
Collaborator

rohitmalhotra1420 commented Jun 13, 2024 •
edited
Loading

Problem:

We have to manually update the push sdk and dapp with exp and alpha release to test and merge the changes every time, which is quite time consuming.

Solution:

  • When a PR is raised on push sdk we will be deploying a previewing for DApp repo with the changes done on SDK and directly test them out without have them to update them in DApp repo manually.
  • The PR will have a link posted on it for the preview which will contain the changes done in that particular sdk PR.
  • This will be applicable for the changes of both uiweb package.
  • The deploy preview will only start when will will add a certain label to the PR to avoid deploying the preview for unrelated PRs.
@rohitmalhotra1420 rohitmalhotra1420 self-assigned this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohitmalhotra1420 rohitmalhotra1420

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rohitmalhotra1420