Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added relative imports for better management #1289

Merged
merged 1 commit into from
May 16, 2024

Conversation

HarshRajat
Copy link
Contributor

Closes #1288

Changes proposed

Babel plugin to resolve relative imports

Copy link

In the .babelrc file:

  1. The "styled-components" plugin is incorrectly configured. It should be structured like this:
["styled-components", { "pure": true, "ssr": true }]
  1. "module-resolver" plugin is not properly configured. It should be an array with configurations inside it. Correct format:
["module-resolver", {
  "root": ["./src"],
  "alias": {
    "components": "./src/lib/components"
  }
}]

File: packages/uiweb/package.json

  1. There is a missing closing brace } after the "dependencies" section.
  2. The "peerDependencies" section is missing a closing brace } after the styled-components version.
  3. The "devDependencies" section is missing a closing brace } after the babel-plugin-module-resolver version.

After fixing the above issues, the code should be reviewed again for any logic errors or typos.

All looks good.

@HarshRajat HarshRajat changed the base branch from main to alpha May 15, 2024 17:13
Copy link
Collaborator

@rohitmalhotra1420 rohitmalhotra1420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@HarshRajat HarshRajat merged commit 9e7432e into alpha May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Improvement Proposal] - Adding babel relative imports to better manage UIWeb sdk
2 participants