Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase guarantee that Verdaccio server is closed on error #46

Open
getlarge opened this issue Sep 30, 2024 · 3 comments
Open

Increase guarantee that Verdaccio server is closed on error #46

getlarge opened this issue Sep 30, 2024 · 3 comments
Assignees
@getlarge
Labels
🐛 bug Something isn't working

Comments

@getlarge
Copy link
Collaborator

Screenshot 2024-09-30 at 10 49 12

While improving the whole e2e experience, we might as well avoid leaving hundreds of undesired processes on the user's machine.
@getlarge getlarge self-assigned this Sep 30, 2024
@getlarge getlarge added the 🐛 bug Something isn't working label Sep 30, 2024
@getlarge
Copy link
Collaborator Author

After considering it, this could more easily work if e2e tasks are run inside your own executor, where you can control the complete execution flow (e2e + env setup).
This way, you can ensure that the server will be closed whenever the task is completed or failed.

This idea of an e2e task wrapper could also help with task distribution...

@BioPhoton
Copy link
Contributor

ATM the cleanup is not fully there. The idea would be to handle those errors in the setup executor directly inc the cleanup on error. Verdaccio is started in there too.

@getlarge
Copy link
Collaborator Author

many cases should be handled by #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getlarge getlarge

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BioPhoton @getlarge