From 44c8e5eb4f6d2a1741097610877cac635785e6d7 Mon Sep 17 00:00:00 2001 From: Michael Date: Mon, 9 Sep 2024 15:36:00 +0300 Subject: [PATCH] add comments --- e2e-examples/cli-e2e-original/tooling/original.plugin.ts | 2 +- projects/cli/src/lib/cli.ts | 4 ++-- tooling/build-env/src/shared/setup.ts | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/e2e-examples/cli-e2e-original/tooling/original.plugin.ts b/e2e-examples/cli-e2e-original/tooling/original.plugin.ts index bdcb41f6..ce3ce3d6 100644 --- a/e2e-examples/cli-e2e-original/tooling/original.plugin.ts +++ b/e2e-examples/cli-e2e-original/tooling/original.plugin.ts @@ -45,7 +45,7 @@ function verdaccioTargets(): Record { options: { config: '.verdaccio/config.yml', storage: `tmp/local-registry/storage`, - port: 4200, + port: 4210, }, }, }; diff --git a/projects/cli/src/lib/cli.ts b/projects/cli/src/lib/cli.ts index 07692397..4d5f3161 100644 --- a/projects/cli/src/lib/cli.ts +++ b/projects/cli/src/lib/cli.ts @@ -1,11 +1,11 @@ -import yargs, { Options } from 'yargs'; +import yargs, {Argv, Options} from 'yargs'; import { sortUserFile } from '@org/core'; export type CliArgs = { filePath: string; }; -const NOOP_BUILDER = undefined; +const NOOP_BUILDER = (_: Argv) => {}; export function cli(args: string[]) { return yargs(args) .version(false) diff --git a/tooling/build-env/src/shared/setup.ts b/tooling/build-env/src/shared/setup.ts index 6360d7f3..733296a2 100644 --- a/tooling/build-env/src/shared/setup.ts +++ b/tooling/build-env/src/shared/setup.ts @@ -8,7 +8,8 @@ export function getEnvironmentsRoot( } /** - * bx default takes the project name of the current task target + * Nx by default takes the project name of the current task target (env.NX_TASK_TARGET_PROJECT) + * * @param projectName * @param environmentsDir */