Collect exceptions caught during shutdown #297
Conversation
|
|
| e (ex-info msg {:errors errors})] | ||
| (log/error e msg) | ||
| (when throw? | ||
| (throw e))) |
There was a problem hiding this comment.
Possible regression: Perhaps (if thrown? (throw e) this) to avoid breaking changes.
| (map (fn [[service-id s]] | ||
| (try | ||
| (run-lifecycle-fn! app-context s/stop "stop" service-id s) | ||
| :ok |
There was a problem hiding this comment.
Style: Perhaps we could return nil here and use keep instead of map. Maybe then we could remove the promise-chan transducer.
There was a problem hiding this comment.
I think you are right, it looks much cleaner. Actually I begin with that idea but later my thought drifted towards "results-chan" instead of "errors-chan" as a holder for statuses not only for "failed to stop" services but also for the others, like "service finished but there is a list of pending jobs"
|
Excellent! Thank you both so much for working on this. Would you mind also updating the CHANGELOG file? We can then do a release with these changes on Monday. |
|
Looking forward for the Monday release :) Also there was three releases missing in CHANGELOG.md. I added some notes based of comparing the tags but please check them out. And have a great weekend :) |
|
Hi! @justinstoller, sorry for bothering you. Are you still planning to cut the release any time soon? The release is not urgent; I want to ensure that I didn't miss something obvious in my PR. |
|
Thanks for the reminder, we should get on this. I'll look into it today 🙂 |
|
This has been released https://github.com/puppetlabs/trapperkeeper/releases/tag/3.2.0 |
|
Amazing! Thank you very much for the quick response! |
fix #292