Git: Short SHA performance #560
Comments
|
Hey @giggsey thanks for this. It's a solid suggestion. I'll do some testing with the updated command in the description and see what comes up. In the meantime - if you have already implemented this, a PR would be welcome. We could work with you to get it merged. |
As pointed out in #560, the check for SHA equality only currently works for long shas which are 40 characters. If a short SHA with :revision rev-parse HEAD returns a long SHA therefore rendering the equality check false. e.g "cb1eb6" != "cb1eb6bb33eb6889818f5b02aa593b4ff2f8ca33" This commit updates the args so that rev-parse will always return a SHA that is the same length as the value provided with the :revision parameter. This will cause the check to be true and exit get_revision early as it would do when both values are 40 characters.
|
Hello! 👋 This issue has been open for a while and has had no recent activity. We've labelled it with If you are waiting on a response from us we will try and address your comments on a future Community Day. Alternatively, if it is no longer relevant to you please close the issue with a comment. |
|
Completed? |
|
Sorry, this was marked as inactive and closed by our outdated automated system some time ago. We no longer close inactive issues based on inactivity without confirmation. Re-opening this issue. |
Use Case
There is also an optimisation if the cloned repo is at the correct revision: https://github.com/puppetlabs/puppetlabs-vcsrepo/blob/main/lib/puppet/provider/vcsrepo/git.rb#L529-L532 introduced in #380
But this only works with full SHAs.
When the SHA isn't an exact match, a
git fetchis run, which can potentially be slow for large reposDescribe the Solution You Would Like
git rev-parse HEADis used to get the current commit for use in comparison, which returns the full sha.Could that command change to
git rev-parse --short={@resource.value(:revision).length} HEADfor the comparison?This would then match, and not bother with the rest of the
get_revisionfunction.The text was updated successfully, but these errors were encountered: