Change in v5.2.0 causes "Could not evaluate: undefined method `dir' for nil:NilClass" on Windows

[aaronhilton0]

Describe the Bug

Since the release of v5.2.0, when using the vcsrepo module on Windows customer gets the error "Could not evaluate: undefined method `dir' for nil:NilClass" on every run. Problem does not occur with v5.1.0 of this module.

Expected Behavior

Repository should be handled without error

Steps to Reproduce

Error is consistent using module as follows

class profile::vcsrepotest {
  vcsrepo { "C:/admkrdev.ide/Jobs":
    ensure   => latest,
    provider => git,
    source   => '[email protected]:aaronhilton0/control-repo.git',
    identity => 'C:/keys/id_rsa',
  }
}

Environment

• Windows Server 2019
• Puppet Enterprise 2021.5

Additional Context

Currently affecting customer on ticket 48952

[pmcmaw]

For future reference, this is being listed as a feature and not a bug as currently this module does not currently support Windows.

[krische]

Is it still easy enough to fix this? I've been using this module on Windows for years without any problems until 5.2.0.

[pmcmaw]

Unfortunately it isn't something we would be planning on looking at.
However this module is open source and we would be more than happy to accept a PR if it is something you would be interested in.

[github-actions]

Hello! 👋

This issue has been open for a while and has had no recent activity. We've labelled it with attention-needed so that we can get a clear view of which issues need our attention.

If you are waiting on a response from us we will try and address your comments on a future Community Day.

Alternatively, if it is no longer relevant to you please close the issue with a comment.

[kenyon]

Not stale, there's an open pull request for this.