(CONT-799) Rubocop Fixes 13-15

- RSpec/ContextWording
- RSpec/ExampleLength
- RSpec/MultipleExpectations

Author: david22swan

.rubocop.yml

@@ -83,3 +83,5 @@ Style/Documentation:
   - spec/**/*
 Style/WordArray:
   EnforcedStyle: brackets
+RSpec/MultipleExpectations:
+  Max: 3

.rubocop_todo.yml

@@ -6,26 +6,11 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 33
-# Configuration parameters: Prefixes, AllowedPatterns.
-# Prefixes: when, with, without
-RSpec/ContextWording:
-  Exclude:
-    - 'spec/acceptance/listen_spec.rb'
-    - 'spec/classes/haproxy_spec.rb'
-    - 'spec/defines/balancermember_spec.rb'
-    - 'spec/defines/instance_spec.rb'
-
 # Offense count: 22
 # Configuration parameters: IgnoredMetadata.
 RSpec/DescribeClass:
   Enabled: false
 
-# Offense count: 3
-# Configuration parameters: CountAsOne.
-RSpec/ExampleLength:
-  Max: 7
-
 # Offense count: 66
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
@@ -48,10 +33,6 @@ RSpec/ImplicitSubject:
     - 'spec/defines/resolver_spec.rb'
     - 'spec/defines/userlist_spec.rb'
 
-# Offense count: 15
-RSpec/MultipleExpectations:
-  Max: 3
-
 # Offense count: 3
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:

spec/acceptance/basic_spec.rb

@@ -55,8 +55,8 @@ class { 'haproxy': }
         end
       end
 
-      it 'has stats listening on each port' do
-        ['9090', '9091'].each do |port|
+      ['9090', '9091'].each do |port|
+        it "port #{port} has stats listening on each port" do
           run_shell("/usr/bin/curl -u puppet:puppet localhost:#{port}") do |r|
             expect(r.stdout).to contain %r{HAProxy}
             expect(r.exit_code).to eq 0
@@ -85,8 +85,8 @@ class { 'haproxy': }
         end
       end
 
-      it 'has stats listening on each port' do
-        ['9090', '9091'].each do |port|
+      ['9090', '9091'].each do |port|
+        it "port #{port} has stats listening on each port" do
           run_shell("/usr/bin/curl -u puppet:puppet localhost:#{port}") do |r|
             expect(r.stdout).to contain %r{HAProxy}
             expect(r.exit_code).to eq 0

spec/acceptance/frontbackend_spec.rb

@@ -35,7 +35,7 @@ class { 'haproxy': }
   # This is not great since it depends on the ordering served by the load
   # balancer. Something with retries would be better.
   # C9945
-  it 'does a curl against the LB to make sure it gets a response from each port' do
+  it 'does a curl against the LB to make sure it gets a response from each port' do # rubocop:disable RSpec/ExampleLength
     response_connection = run_shell('curl localhost:5555').stdout.chomp
     expect(response_connection).to match(%r{Response on 555(6|7)})
     if response_connection == 'Response on 5556'

spec/acceptance/listen_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper_acceptance'
 
 describe 'listen define' do
-  context 'pp_one' do
+  context 'with standard setup' do
     pp_one = <<-PUPPETCODE
         class { 'haproxy': }
         haproxy::listen { 'app00':
@@ -36,7 +36,7 @@ class { 'haproxy': }
     end
   end
 
-  context 'pp_two' do
+  context 'with options' do
     # C9955
     pp_two = <<-PUPPETCODE
         class { 'haproxy': }
@@ -71,7 +71,7 @@ class { 'haproxy': }
   end
   # C9942 C9944 WONTFIX
 
-  context 'pp_three' do
+  context 'with one node up' do
     # C9943
     pp_three = <<-PUPPETCODE
         class { 'haproxy': }
@@ -102,7 +102,7 @@ class { 'haproxy': }
     end
   end
 
-  context 'pp_three' do
+  context 'with no addess' do
     pp_four = <<-PUPPETCODE
         class { 'haproxy': }
           haproxy::listen { 'app0':

spec/classes/haproxy_spec.rb

@@ -14,7 +14,7 @@
 
   describe 'for OS-agnostic configuration' do
     ['Debian', 'RedHat', 'Archlinux', 'FreeBSD', 'Gentoo'].each do |osfamily|
-      context "on #{osfamily} family operatingsystems" do
+      context "when on #{osfamily} family operatingsystems" do
         let(:facts) do
           { os: { family: osfamily } }.merge default_facts
         end
@@ -40,7 +40,7 @@
         end
       end
 
-      context "on #{osfamily} specifying a package version" do
+      context "when on #{osfamily} specifying a package version" do
         let(:facts) do
           { os: { family: osfamily } }.merge default_facts
         end
@@ -67,7 +67,7 @@
       end
 
       # C9938
-      context "on #{osfamily} when specifying custom content" do
+      context "when on #{osfamily} when specifying custom content" do
         let(:facts) do
           { os: { family: osfamily } }.merge default_facts
         end
@@ -86,7 +86,7 @@
 
   describe 'for linux operating systems' do
     ['Debian', 'RedHat', 'Archlinux', 'Gentoo'].each do |osfamily|
-      context "on #{osfamily} family operatingsystems" do
+      context "when on #{osfamily} family operatingsystems" do
         let(:facts) do
           { os: { family: osfamily } }.merge default_facts
         end
@@ -155,7 +155,7 @@
         end
       end
 
-      context "on #{osfamily} family operatingsystems with setting haproxy.cfg location" do
+      context "when on #{osfamily} family operatingsystems with setting haproxy.cfg location" do
         let(:facts) do
           { os: { family: osfamily } }.merge default_facts
         end
@@ -174,7 +174,7 @@
         end
       end
 
-      context "on #{osfamily} family operatingsystems without managing the service" do
+      context "when on #{osfamily} family operatingsystems without managing the service" do
         let(:facts) do
           { os: { family: osfamily } }.merge default_facts
         end
@@ -257,7 +257,7 @@
         end
       end
 
-      context "on #{osfamily} when specifying a restart_command" do
+      context "when on #{osfamily} when specifying a restart_command" do
         let(:facts) do
           { os: { family: osfamily } }.merge default_facts
         end
@@ -461,7 +461,7 @@
     # Debian OS family so that we don't have to juggle different sets of
     # global_options and defaults_options (like for FreeBSD).
     ['Debian'].each do |osfamily|
-      context "on #{osfamily} family operatingsystems" do
+      context "when on #{osfamily} family operatingsystems" do
         let(:facts) do
           { os: { family: osfamily } }.merge default_facts
         end
@@ -572,7 +572,7 @@
     # Debian OS family so that we don't have to juggle different sets of
     # global_options and defaults_options (like for FreeBSD).
     ['Debian'].each do |osfamily|
-      context "on #{osfamily} family operatingsystems" do
+      context "when on #{osfamily} family operatingsystems" do
         let(:facts) do
           { os: { family: osfamily } }.merge default_facts
         end

spec/defines/balancermember_spec.rb

@@ -199,7 +199,7 @@
     }
   end
 
-  context 'server-template' do
+  context 'with server-template' do
     let(:params) do
       {
         name: 'tyler',
@@ -218,7 +218,7 @@
     }
   end
 
-  context 'server-template with port' do
+  context 'with server-template with port' do
     let(:params) do
       {
         name: 'tyler',
@@ -238,7 +238,7 @@
     }
   end
 
-  context 'server-template with port with num amount' do
+  context 'with server-template with port with num amount' do
     let(:params) do
       {
         name: 'tyler',
@@ -259,7 +259,7 @@
     }
   end
 
-  context 'server-template with port with range amount' do
+  context 'with server-template with port with range amount' do
     let(:params) do
       {
         name: 'tyler',
@@ -280,7 +280,7 @@
     }
   end
 
-  context 'server-template with port with range amount with server prefix' do
+  context 'with server-template with port with range amount with server prefix' do
     let(:params) do
       {
         name: 'tyler',
@@ -302,7 +302,7 @@
     }
   end
 
-  context 'server-template with port with range amount with server prefix with options' do
+  context 'with server-template with port with range amount with server prefix with options' do
     let(:params) do
       {
         name: 'tyler',
@@ -325,7 +325,7 @@
     }
   end
 
-  context 'server-template with port with range amount with server prefix with multiple options' do
+  context 'with server-template with port with range amount with server prefix with multiple options' do
     let(:params) do
       {
         name: 'tyler',
@@ -348,7 +348,7 @@
     }
   end
 
-  context 'server-template with port with range amount with server prefix with options with weight' do
+  context 'with server-template with port with range amount with server prefix with options with weight' do
     let(:params) do
       {
         name: 'tyler',
@@ -372,7 +372,7 @@
     }
   end
 
-  context 'server-template with port with range amount with server prefix with options with weight with cookies' do
+  context 'with server-template with port with range amount with server prefix with options with weight with cookies' do
     let(:params) do
       {
         name: 'tyler',
@@ -397,7 +397,7 @@
     }
   end
 
-  context 'server-template with port with range amount with server prefix with options with weight with cookies with verifyhost' do
+  context 'with server-template with port with range amount with server prefix with options with weight with cookies with verifyhost' do
     let(:params) do
       {
         name: 'tyler',

spec/defines/instance_spec.rb

@@ -23,7 +23,7 @@
 
     describe 'for OS-agnostic configuration' do
       ['Debian', 'RedHat', 'Archlinux', 'FreeBSD'].each do |osfamily|
-        context "on #{osfamily} family operatingsystems" do
+        context "when on #{osfamily} family operatingsystems" do
           let(:facts) do
             { os: { family: osfamily } }.merge default_facts
           end
@@ -50,7 +50,7 @@
           end
         end
 
-        context "on #{osfamily} family specifying a package version" do
+        context "when on #{osfamily} family specifying a package version" do
           let(:facts) do
             { os: { family: osfamily } }.merge default_facts
           end
@@ -78,7 +78,7 @@
         end
 
         # C9938
-        context "on #{osfamily} when specifying custom content" do
+        context "when on #{osfamily} when specifying custom content" do
           let(:facts) do
             { os: { family: osfamily } }.merge default_facts
           end
@@ -97,7 +97,7 @@
 
     describe 'for linux operating systems' do
       ['Debian', 'RedHat', 'Archlinux'].each do |osfamily|
-        context "on #{osfamily} family operatingsystems" do
+        context "when on #{osfamily} family operatingsystems" do
           let(:facts) do
             { os: { family: osfamily } }.merge default_facts
           end
@@ -265,7 +265,7 @@
           end
         end
 
-        context "on #{osfamily} when specifying a restart_command" do
+        context "when on #{osfamily} when specifying a restart_command" do
           let(:facts) do
             { os: { family: osfamily } }.merge default_facts
           end
@@ -293,7 +293,7 @@
 
     describe 'for OS-agnostic configuration' do
       ['Debian', 'RedHat', 'Archlinux', 'FreeBSD'].each do |osfamily|
-        context "on #{osfamily} family operatingsystems" do
+        context "when on #{osfamily} family operatingsystems" do
           let(:facts) do
             { os: { family: osfamily } }.merge default_facts
           end
@@ -331,7 +331,7 @@
         end
 
         # C9938
-        context "on #{osfamily} when specifying custom content" do
+        context "when on #{osfamily} when specifying custom content" do
           let(:facts) do
             { os: { family: osfamily } }.merge default_facts
           end
@@ -350,7 +350,7 @@
 
     describe 'for linux operating systems' do
       ['Debian', 'RedHat', 'Archlinux'].each do |osfamily|
-        context "on #{osfamily} family operatingsystems" do
+        context "when on #{osfamily} family operatingsystems" do
           let(:facts) do
             { os: { family: osfamily } }.merge default_facts
           end
@@ -419,7 +419,7 @@
           end
         end
 
-        context "on #{osfamily} family operatingsystems without managing the service" do
+        context "when on #{osfamily} family operatingsystems without managing the service" do
           let(:facts) do
             { os: { family: osfamily } }.merge default_facts
           end
@@ -503,7 +503,7 @@
           end
         end
 
-        context "on #{osfamily} when specifying a restart_command" do
+        context "when on #{osfamily} when specifying a restart_command" do
           let(:facts) do
             { os: { family: osfamily } }.merge default_facts
           end