Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip Output and secret types from detailed diff input #2526

Closed
VenelinMartinov opened this issue Oct 29, 2024 · 3 comments · Fixed by #2643
Closed

Strip Output and secret types from detailed diff input #2526

VenelinMartinov opened this issue Oct 29, 2024 · 3 comments · Fixed by #2643
Assignees
@VenelinMartinov
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@VenelinMartinov
Copy link
Contributor

VenelinMartinov commented Oct 29, 2024 •
edited
Loading

The detailed diff algorithm in the bridge does not need to care about secrets as it can not expose these. We should make sure that these are not passed in.

Currently the bridge uses a flag to the engine to say that both Secrets and Outputs are not supported but this might change with #1506
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Oct 29, 2024
@VenelinMartinov VenelinMartinov changed the title Strip Output types from detailed diff input Strip Output and secret types from detailed diff input Oct 29, 2024
@VenelinMartinov VenelinMartinov added kind/engineering Work that is not visible to an external user and removed needs-triage Needs attention from the triage team labels Oct 29, 2024
@VenelinMartinov VenelinMartinov mentioned this issue Oct 29, 2024
Merged
@t0yv0
Copy link
Member

t0yv0 commented Nov 1, 2024

Thank you for logging this. I think it is not a problem as of today (AFAIK), but will become one with #1506 so that would be something we need to account for if doing that.

@VenelinMartinov VenelinMartinov mentioned this issue Nov 20, 2024
Merged
@VenelinMartinov
Copy link
Contributor Author

Turns out this is necessary for PF support, working on a fix in #2643

@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Nov 26, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #2643 and shipped in release v3.97.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VenelinMartinov VenelinMartinov

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Detailed diff handle secrets and outputs pulumi/pulumi-terraform-bridge
3 participants
@t0yv0 @VenelinMartinov @pulumi-bot