deployment template: fix extraSidecars indentation

[zackse]

Proposed changes

In the deployment template, the extraSidecars object is indented too far, resulting in malformed YAML.

# test-values.yaml
extraSidecars:
  - name: busy-beaver
    image: busybox
    command: ["sh", "-c"]
    args: ["sleep 999999"]

cd pulumi-kubernetes-operator/deploy/helm/pulumi-operator
helm template . -f test-values.yaml

Error: YAML parse error on pulumi-kubernetes-operator/templates/deployment.yaml: error converting YAML to JSON: yaml: line 34: did not find expected key

This change reduces the indentation to match the manager entry in the containers list.

Notes

• Ideally this can be included in the 0.8.x release train as 2.x is still unreleased
• As far as I can tell, this has been an issue since the file was introduced in feat: add helm chart #379
• Aside, the PR template has a reference to CONTRIBUTING.md, but that file doesn't seem to exist in the repo

[github-actions]

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

[EronWright]

Thanks for the fix!

[EronWright]

I'll take care to merge this PR when we do our next release.